search

Piwigo / Piwigo-Android

Piwigo Native Android App
GNU General Public License v3.0
140 stars 43 forks source link

fix #264 #265

Closed ramack closed 3 years ago

ramack commented 3 years ago

I guess this would fix the issue, as we have removed the PropertyChangedCallback(mDrawerCallBack) in MainActivity.onPause() but registered it in onCreate() instead of onResume()...

ramack commented 3 years ago

@remi-martin is this one-liner worth to review? Do you want to take a look? - I am a friend of the 4-eyes principle, so I'd appreciate if you'd want to, but we can also just merge it if you want. But I also know about your working time, so we don't need to rush here, it can wait until next week! - The travis-tests are not (yet) stable, so I wouldn't count too much on the them failing. (Even though CI testing is a great tool and it would be great to have progress here, but I personally miss the experience to actively work on that.)

remi-martin commented 3 years ago

I usually never use any Review or CI, so I'll follow your choices