Open jonlm opened 1 month ago
@jonlm Out of curiosity, did you need HDF5 support for a particular reason or were you just testing things out? I was under the impression that HDF5 wasn't really used anymore in favor of Ogawa.
Don't specifically need it, was building it with everything turned on just for completeness. I agree that HDF5 Alembic files are very unlikely to be encountered by anyone who isn't pulling archival data. That said, the 2016 HDF5 version is probably not a great thing to be offering up as an option given that CVEs have been addressed, etc..
Agreed -- given its lack of use I think I'd prefer to address this by dropping HDF5 support rather than updating the dependency, but I'll discuss this with folks. Thanks for the report!
My 2¢ is that the folks who need legacy alembic support, are also the people most likely able to build Alembic themselves outside of the build_usd.py with it.
For timeline of use, Alembic was 2010 release. Ogawa was 2013 release. Adding in how long it takes people to adopt new tech, I think it's likely that very few people actually have significant HDF5 Alembics today.
I think it's worth removing HDF5 support at this point.
Filed as internal issue #USD-9834
Description of Issue
Building on macOS Sonoma with XCode 15.3 and Alembic + HDF5 enabled fails with this error:
I found some discussion of this same problem here:
"The -Wint-conversion warning diagnostic for implicit int <-> pointer conversions now defaults to an error in all C language modes. It may be downgraded to a warning with -Wno-error=int-conversion, or disabled entirely with -Wno-int-conversion." https://releases.llvm.org/15.0.0/tools/clang/docs/ReleaseNotes.html
The hdf5 version (1.10.0 patch 1) is from 2016, so this isn't too surprising. I tried replacing it with the latest version of 1.10, but in order for it to build I had to remove this chunk of code from build_usd.py since neither patch cleanly applies anymore, nor seems to be necessary:
At that point it did build fine, however I didn't test any hdf5 alembic files so I can't speak to the correctness of the build.
Related commits: https://github.com/PixarAnimationStudios/OpenUSD/commit/5e280f6ffb37e350a7011ed9227667cbf4b881ec https://github.com/PixarAnimationStudios/OpenUSD/commit/83ed6c36e0732dc17b4d77795800c67b0fbefac4
System Information (OS, Hardware)
macOS 14.5, XCode 15.3, clang "15.0.0 (clang-1500.3.9.4)"
Package Versions
USD 24.05
Build Flags
build_usd.py --build-variant release --openimageio --opencolorio --alembic --hdf5 --draco --materialx --ptex