build_usd.py: potential file name collisions

PixarAnimationStudios / OpenUSD

Universal Scene Description

http://www.openusd.org

Other

6.18k stars 1.23k forks source link

build_usd.py: potential file name collisions #457

Open jcowles opened 6 years ago

jcowles commented 6 years ago

Description of Issue

build_usd.py downloads several zip files, many of which are not prefixed with a library name. Here is a sample of what my $build/src directory contains:

1.5.1.zip
1.7.1.zip
v2.2.0.zip
v3_1_1.zip

These file names may one day collide, but more immediately, it makes it harder to determine which library each file contains.

System Information (OS, Hardware)

Windows

Package Versions

USD v0.8.4

jtran56 commented 6 years ago

Filed as internal issue #159450.

Cewein commented 7 months ago

The possible collision is still here with https://github.com/PixarAnimationStudios/OpenUSD/blob/2864f3d04f396432f22ec5d6928fc37d34bb4c90/build_scripts/build_usd.py#L543

I'll will look into it. For gitlab and github url it should be ok.

For example this could work :

url.split("/")[4] + "-" + url.split("/")[-1]

it would give for this type of url : https://github.com/oneapi-src/oneTBB/archive/refs/tags/v2020.3.zip This result : oneTBB-v2020.3.zip