search

Pkmmte / PkRSS

A powerful RSS feed manager for Android
Apache License 2.0
100 stars 23 forks source link

Callback thread and reference #5

Closed vincentbrison closed 8 years ago

vincentbrison commented 9 years ago

Hi, This library looks really promising !

But as you mentioned in this commit : https://github.com/Pkmmte/TechDissected/commit/47da228f035704b8c3bd543e411a5ee78be33eb3 it would be great if callback are called by default on the main thread. It looks very disturbing from the controller point of view to set a callback, call async, and get the result on a thread it did not create at all. I saw you implemented this on an 1.1.3 snapshot, is there any chance to get this release through maven ?

By the way, it would be also great to hold only weak references on callbacks, since we obviously do not want any fragment or activity held by the downloader and parser threads of your library.

esoxjem commented 9 years ago

Any update on this? Callback should be on the main thread. Or the API could ask for the thread where callbacks should happen.

Pkmmte commented 9 years ago

The commits to improve this have been pushed. I'll deploy an update to Maven once I find my key...

esoxjem commented 9 years ago

Is this on Gradle yet? :)

Pkmmte commented 9 years ago

Yup! Version 1.2 has been released a couple days ago on Maven.