PlanBCode / hypha

1 stars 8 forks source link

Improve comment links #364

Closed matthijskooijman closed 3 years ago

matthijskooijman commented 3 years ago

This adresses some problems with the comment links feature merged in #356, as discussed in https://github.com/PlanBCode/hypha/pull/356#issuecomment-743437016 onwards.

This PR contains the commits previously pushed by @RoukePouw, but I:

@RoukePouw, how does this look? If this looks ok to you and the php-dom-wrapper maintainer applies this fix upstream, I think this addresses everything?

RoukePouw commented 3 years ago

Looks great! :)

matthijskooijman commented 3 years ago

I've rebased this on master, and squashed the fixups. I want to go ahead and merge this even though phpdomwrapper's maintainer has not responded yet, we can always update our fix when they do.

@RoukePouw, I also noticed that in one of your commits, you removed the u modifier on the regex, which enables UTF-8 processing. Was that intentional? It looks like having that modifier is correct, so I modified your commits to leave it now.