PlasmaControl / DESC

Stellarator Equilibrium and Optimization Suite
MIT License
99 stars 26 forks source link

Should OmnigenousField disallow certain helicity types? #1390

Open dpanici opened 1 week ago

dpanici commented 1 week ago

https://github.com/PlasmaControl/DESC/blob/95612fa625bd5ba939569004c767ed02594586f0/desc/magnetic_fields/_core.py#L2404

dpanici commented 5 days ago

basically, should we throw an error if the field has a certain NFP but a different toroidal helicity (say 1 instead of NFP) is passed in?