PluginBugs / Issues-ItemsAdder

Repository used to keep track of issues of my plugin ItemsAdder
https://itemsadder.devs.beer
52 stars 21 forks source link

Players cant use tripwire regardless of disable_REAL_TRIPWIRE being set to true/false #1475

Closed Akiranya closed 2 years ago

Akiranya commented 2 years ago

Terms

Discord tag (optional)

Nailm#9364

What happened?

I would like to allow my players to use tripwire like they would do in the vanilla game. Like in the vanilla game, players could connect two tripwires using wires, and walk across the wire to trigger the tripwire. But with Itemsadder, a message showing "tripwire is disabled in the server" will appear when the players try to connect the tripwire using wire. This happens regardless of the config "disable real_wire" being true/false.

Steps to reproduce the issue

image

With default IA config, build a structure like this, and connect the tripwires using a wire. Then the message showing "tripwire is disabled in the server" will appear regardless of the config "disable real_wire" being true/false.

Server version

ItemsAdder Version

[19:31:28 INFO]: ItemsAdder version 2.5.2 [19:31:28 INFO]: Customized Minecraft without client mods! [19:31:28 INFO]: Website: devs.beer [19:31:28 INFO]: Author: LoneDev

ProtocolLib Version

[19:31:41 INFO]: ProtocolLib version 4.8.0-SNAPSHOT-b540 [19:31:41 INFO]: Provides read/write access to the Minecraft protocol. [19:31:41 INFO]: Authors: dmulloy2 and comphenix

LoneLibs Version

[19:31:52 INFO]: LoneLibs version 1.0.16b [19:31:52 INFO]: Collection of libs used by my plugins [19:31:52 INFO]: Authors: LoneDev and others

LightAPI Version (optional)

No response

LibsDisguises Version (optional)

No response

FULL server log

There is no error or warning on the console :w

Error (optional)

No response

ItemsAdder config.yml

metrics: true
update-checker: false
disable-plugin-loading-messages_DONT_ASK_ME_FOR_SUPPORT_IF_YOU_SET_TRUE__THANKS: false
resource-pack:
  hosting:
    no-host:
      enabled: true
    auto-external-host:
      enabled: false
    self-host:
      enabled: false
      server-ip: 127.0.0.1
      pack-port: 8163
    external-host:
      enabled: false
      url: ''
      skip-url-file-type-check___DONT_ASK_HELP_IF_SET_TRUE: false
  apply-on-join: false
  kick-player-on-decline: false
  kick-player-on-fail: false
  delay-ticks: 100
  notify-other-plugins-interfering: true
  title:
    enabled: true
  protect-player:
    black-screen: true
    hide-hud: true
    cancel-movement: true
    lock-player: true
  command:
    usage-cooldown-seconds: 60
  custom-font:
    enabled: false
    name: ipaexg.ttf
    shift: '[0,0]'
    size: 11.0
    oversample: 2.0
  thin-font:
    enabled: true
  zip:
    protect-file-from-unzip:
      enabled: true
      extreme: true
    compress-png-files: true
    compress-json-files: true
    overwrite-vanilla-models: true
    overwrite-vanilla-lang-json: true
    generate-custom-armors-textures:
      _: 'Available values: VANILLA_1_17 or OPTIFINE'
      enabled: true
      mode: VANILLA_1_17
    disable-overwrite-leather-armor-layers-textures: false
    fix_transparent_noteblocks__disable-for-more-performance: false
    ignore-files-ext:
    - db
    - yml
    - xcf
    - html
  items:
    CustomModelData-starting-value:
      ALL: 50000
      DIAMOND: 51000
config_files:
  lang: zh_cn
  dictionaries-lang: zh_cn
  extract-default-items: false
  extract-default-resources: false
blocks:
  light-api: true
  fix-glitched-blocks:
    enabled: true
    only-new-chunks: false
    search-also-in-these-biomes:
      enabled: false
      biomes:
      - BEACH
      - BIRCH_FOREST
      - BIRCH_FOREST_HILLS
      - FOREST
      - MOUNTAINS
      - MOUNTAIN_EDGE
      - GRAVELLY_MOUNTAINS
      - PLAINS
      - RIVER
  cancel-break-wrong-tool:
    enabled: true
    send-actionbar: true
  campfire:
    unlit-on-place: true
    allow-any-item: true
  disable-REAL: true
  disable-REAL_TRANSPARENT: true
  disable-REAL_NOTE: true
  disable-REAL_WIRE: true
  disable-FIRE: true
items:
  fix-show-attack-and-damage-as-lore: true
  give_death_location_maps: false
  hide-custom-durability-lore: false
liquids:
  enabled: false
huds:
  enabled: false
mobs:
  disable-MOB-behaviour__DISABLE_AT_YOUR_OWN_RISK: false
font_images:
  chat:
    enabled: true
    doublecheck-permission__disable-for-more-performance: false
    add-hover-suggestion: true
  command:
    enabled: true
    commandblocks: true
    excluded:
    - home
    - sethome
    - tpa
  sign:
    enabled: true
  book:
    enabled: true
  anvil:
    enabled: true
  inventory-title:
    enabled: true
  tab-header-footer:
    enabled: true
  vault-prefix-suffix:
    enabled: true
    update-every-ticks: 1200
  scoreboard-teams:
    enabled: true
    update-every-ticks: 3600
  player-display-name:
    enabled: true
    update-every-ticks: 1200
  replace-in-customitems-name-and-lore: true
effects:
  hide-scoreboard-numbers: true
  text-effects:
    enabled: true
    replace-in-customitems-name-and-lore: true
    chat:
      enabled: true
    sign:
      enabled: true
    book:
      enabled: true
    anvil:
      enabled: true
    tab-header-footer:
      enabled: true
entities:
  max-furniture-vehicles-per-chunk: 30
  allow-removing-old-furnitures_2_3_11: false
recipes:
  hide-vanilla-unrecognized-recipe-errors: true
  fix-packet-too-large-kick: false
  custom-recipes:
    unlock:
      all-on-join: false
      on-pickup:
        any: false
        ingredients: true
  remove-vanilla-recipes:
    enabled: false
    list:
      DIAMOND_SWORD: false
      IRON_INGOT: false
debug:
  items:
    log-files-loading: false
    log-items-loading: false
    log-items-loading-disabled: false
    log-font-images-loading: false
    log-huds-loading: false
    log-attribute-modifiers-loading: false
    log-warnings: false
    log-loots-loading: false
    log-loots-loading-disabled: false
    log-armors-loading: false
  recipes:
    log-recipes-loading: false
    log-recipes-loading-disabled: false
    log-recipes-removed-vanilla: false
    log-fix-packet-too-large: false
  resource-pack:
    log-extract-default-resources: true
    log-not-extract-default-resources-already-exist: true
  blocks:
    log-save: false
    log-save-on-unload: false
    log-mined-unknown-blocks: true
  worlds-populators:
    log-loading: false
    log-loading-disabled: false
    log-loading-no-populators: false
    log-loading-no-world: true
    log-generation: false
  trees-populators:
    log-loading: false
    log-loading-disabled: false
    log-loading-no-populators: false
    log-loading-no-world: true
    log-generation: false
  surface-decorators:
    log-loading: false
    log-loading-disabled: false
    log-loading-no-decorators: false
    log-loading-no-world: true
    log-generation: false
  player-stats:
    log-save: false
  performance:
    loading-ms: true
  huds:
    log-triggers: false
  other:
    log-dictionaries-loading: false
    log-liquids-loading: false
    log-minecraft_lang_overwrite-loading: false
  categories:
    log-total-loaded: true
    log-single-loaded: false
    log-single-loaded-overwrite: false
    log-single-skip: false

Problematic items yml configuration file (optional)

No response

Other files, you can drag and drop them here to upload. (optional)

No response

Screenshots/Videos (you can drag and drop files or paste links)

No response

purejosh commented 2 years ago

I'm also having this exact issue.

LoneDev6 commented 2 years ago

a message showing "tripwire is disabled in the server" will appear when the players try to connect the tripwire using wire. This happens regardless of the config "disable real_wire" being true/false.

Are you sure this message is shown even if you set disable-REAL_WIRE: false? It's a bit strange since I have a specific code which doesn't even load the REAL_WIRE module if it's disabled.

I just tested and the disable-REAL_WIRE: false setting works fine, tripwires work. Maybe you need to restart?

purejosh commented 2 years ago

@LoneDev6 SirCraftypants also confirmed this is an issue. And yes, I'm sure that disable-REAL_WIRE: false is set, and I've also restarted. Users are still unable to use tripwires. Still getting the error.

purejosh commented 2 years ago

Tried setting to true, tested, still says "disabled in server". Set back to false, tried again, still disabled.

LoneDev6 commented 2 years ago

I'll do some more tests but this is very strange, the setting does disable completely the wire module of ItemsAdder, it just doesn't load it, I guess there is something wrong going on.

Maybe there are two setting properties with the same name? Check your config again and let me know, thanks! Have a nice day

Akiranya commented 2 years ago

Hi LoneDev and purejosh, I've just checked the config and it's disable-REAL_WIRE: true, meanwhile tripwires work perfectly in my server atm. What I can be sure about is I've restarted the server when the config is set disable-REAL_WIRE: true. This was a weird issue but at least it works without problems atm.

LoneDev6 commented 2 years ago

I still can't reproduce the issue, a complete restart should completely disable the real-wire module.

purejosh commented 2 years ago

Would you like to do a screenshare, so you can see what's happening?

LoneDev6 commented 2 years ago

Would you like to do a screenshare, so you can see what's happening?

Sure, sorry for the delay. I doubt a screenshare can help me, the problem is that setting the property to true MUST disable the module, it's impossible.

blocks: ###### <---- under this category
  light-api: true
  fix-liquids-flow: true
  fix-floating-blocks: true
  fix-glitched-blocks:
    enabled: true
    only-new-chunks: false
    search-also-in-these-biomes:
      enabled: false
      biomes:
        - BEACH
        - BIRCH_FOREST
        - BIRCH_FOREST_HILLS
        - FOREST
        - MOUNTAINS
        - MOUNTAIN_EDGE
        - GRAVELLY_MOUNTAINS
        - PLAINS
        - RIVER
  cancel-break-wrong-tool:
    enabled: true
    send-actionbar: true
  campfire:
    unlit-on-place: true
    allow-any-item: true
  disable-REAL: false
  disable-REAL_TRANSPARENT: false
  disable-REAL_NOTE: false
  disable-REAL_WIRE: true ######### <--------------- here
  disable-FIRE: false

I think you're maybe setting it in the wrong configuration part? Maybe there is a duplicate setting with the same name?

purejosh commented 2 years ago

I'll triple check things in about an hour from now. I'll let you know. No worries on the time.

purejosh commented 2 years ago

I can confirm I'm still getting "tripwires are disabled on this server" messages. I will try in my dev server.

purejosh commented 2 years ago
metrics: true
update-checker: true
disable-plugin-loading-messages_DONT_ASK_ME_FOR_SUPPORT_IF_YOU_SET_TRUE__THANKS: false
resource-pack:
  hosting:
    no-host:
      enabled: false
    auto-external-host:
      enabled: false
    self-host:
      enabled: true
      server-ip: 192.34.113.4
      pack-port: 32103
    external-host:
      enabled: false
      url: ''
      skip-url-file-type-check___DONT_ASK_HELP_IF_SET_TRUE: false
  apply-on-join: true
  kick-player-on-decline: false
  kick-player-on-fail: false
  delay-ticks: 1
  notify-other-plugins-interfering: true
  title:
    enabled: true
  protect-player:
    black-screen: true
    hide-hud: true
    cancel-movement: true
    lock-player: true
  command:
    usage-cooldown-seconds: 60
  custom-font:
    enabled: false
    name: ipaexg.ttf
    shift: '[0,0]'
    size: 11.0
    oversample: 2.0
  thin-font:
    enabled: false
  zip:
    protect-file-from-unzip:
      enabled: false
      extreme: false
    overwrite-vanilla-models: true
    overwrite-vanilla-lang-json: false
    fix_transparent_noteblocks__disable-for-more-performance: false
    ignore-files-ext:
    - db
    - yml
    - xcf
    - html
    compress-png-files: true
    compress-json-files: true
    generate-custom-armors-textures:
      enabled: true
      mode: OPTIFINE
      _: 'Available values: VANILLA_1_17 or OPTIFINE'
    disable-overwrite-leather-armor-layers-textures: false
  items:
    CustomModelData-starting-value:
      ALL: 10000
      DIAMOND: 11000
config_files:
  lang: en
  dictionaries-lang: en
  extract-default-items: false
  extract-default-resources: false
blocks:
  light-api: true
  fix-glitched-blocks:
    enabled: true
    only-new-chunks: false
    search-also-in-these-biomes:
      enabled: false
      biomes:
      - BEACH
      - BIRCH_FOREST
      - BIRCH_FOREST_HILLS
      - FOREST
      - MOUNTAINS
      - MOUNTAIN_EDGE
      - GRAVELLY_MOUNTAINS
      - PLAINS
      - RIVER
  cancel-break-wrong-tool:
    enabled: true
    send-actionbar: true
  campfire:
    unlit-on-place: true
    allow-any-item: true
  disable-REAL: true
  disable-REAL_TRANSPARENT: false
  disable-REAL_NOTE: false
  disable-REAL_WIRE: false
  disable-FIRE: false
  fix-liquids-flow: true
  fix-floating-blocks: true
items:
  fix-show-attack-and-damage-as-lore: true
  give_death_location_maps: true
  hide-custom-durability-lore: true
liquids:
  enabled: true
huds:
  enabled: true
mobs:
  disable-MOB-behaviour__DISABLE_AT_YOUR_OWN_RISK: false
font_images:
  chat:
    enabled: true
    doublecheck-permission__disable-for-more-performance: false
    add-hover-suggestion: true
  command:
    enabled: true
    commandblocks: true
    excluded:
    - home
    - sethome
    - tpa
  sign:
    enabled: true
  book:
    enabled: true
  anvil:
    enabled: true
  inventory-title:
    enabled: true
  tab-header-footer:
    enabled: true
  vault-prefix-suffix:
    enabled: true
    update-every-ticks: 1200
  scoreboard-teams:
    enabled: false
    update-every-ticks: 3600
  player-display-name:
    enabled: true
    update-every-ticks: 1200
  replace-in-customitems-name-and-lore: true
effects:
  hide-scoreboard-numbers: false
  text-effects:
    enabled: true
    replace-in-customitems-name-and-lore: true
    chat:
      enabled: true
    sign:
      enabled: true
    book:
      enabled: true
    anvil:
      enabled: true
    tab-header-footer:
      enabled: true
entities:
  max-furniture-vehicles-per-chunk: 70
  allow-removing-old-furnitures_2_3_11: false
recipes:
  hide-vanilla-unrecognized-recipe-errors: true
  custom-recipes:
    unlock:
      all-on-join: false
      on-pickup:
        any: false
        ingredients: true
  remove-vanilla-recipes:
    enabled: true
    list:
      DIAMOND_SWORD: false
      IRON_INGOT: false
  fix-packet-too-large-kick: false
debug:
  items:
    log-files-loading: false
    log-items-loading: false
    log-items-loading-disabled: false
    log-font-images-loading: false
    log-huds-loading: false
    log-attribute-modifiers-loading: false
    log-warnings: false
    log-loots-loading: false
    log-loots-loading-disabled: false
    log-armors-loading: true
  recipes:
    log-recipes-loading: false
    log-recipes-loading-disabled: false
    log-recipes-removed-vanilla: false
    log-fix-packet-too-large: false
  resource-pack:
    log-extract-default-resources: false
    log-not-extract-default-resources-already-exist: false
  blocks:
    log-save: false
    log-save-on-unload: false
    log-mined-unknown-blocks: true
  worlds-populators:
    log-loading: false
    log-loading-disabled: false
    log-loading-no-populators: false
    log-loading-no-world: true
    log-generation: false
  trees-populators:
    log-loading: false
    log-loading-disabled: false
    log-loading-no-populators: false
    log-loading-no-world: true
    log-generation: false
  surface-decorators:
    log-loading: false
    log-loading-disabled: false
    log-loading-no-decorators: false
    log-loading-no-world: true
    log-generation: false
  player-stats:
    log-save: false
  performance:
    loading-ms: true
  huds:
    log-triggers: false
  other:
    log-dictionaries-loading: false
    log-liquids-loading: false
    log-minecraft_lang_overwrite-loading: false
  categories:
    log-total-loaded: true
    log-single-loaded: false
    log-single-loaded-overwrite: false
    log-single-skip: false
purejosh commented 2 years ago

Weirdly enough, in a testing server that's running a near copy of my itemsadder install, as my main server is, tripwires work but they are visually glitched. The difference is, I set disable-REAL_WIRE: true and these are the results: image

purejosh commented 2 years ago

Setting disable-REAL_WIRE: false on my dev server, restarting, and placing a tripwire hook caused the same bug as originally posted. Gives an error that they're disabled on this server. I will try IA 3.0.3.

purejosh commented 2 years ago

Upgraded to 3.0.3.beta3 and lonelibs. Server is set to disable-REAL_WIRE: false. Attempted to place tripwire, received message that tripwires are disabled. Set disable-REAL_WIRE: true, attempted to place tripwire, and it worked, however it is bugged as the image above shows. Set disable-REAL_WIRE: false again, now tripwires are disabled again. All restarts between setting changes were made.

I will repeat this with all plugins removed, and with IA only.

purejosh commented 2 years ago

Repeated with ALL plugins removed. Tripwires work fine. Repeated with ONLY IA, lonelibs, protocollibs, original behavior still happening. disable-REAL_WIRE: false is currently set, and "tripwires are disabled on this server" is still showing.

purejosh commented 2 years ago

This server is running Paper version git-Paper-175 (MC: 1.18.1) (Implementing API version 1.18.1-R0.1-SNAPSHOT) (Git: 9490475) You are 41 version(s) behind Download the new version at: https://papermc.io/downloads Previous version: git-Paper-76 (MC: 1.18.1)

LoneDev6 commented 2 years ago

Upgraded to 3.0.3.beta3 and lonelibs. Server is set to disable-REAL_WIRE: false. Attempted to place tripwire, received message that tripwires are disabled. Set disable-REAL_WIRE: true, attempted to place tripwire, and it worked, however it is bugged as the image above shows. Set disable-REAL_WIRE: false again, now tripwires are disabled again. All restarts between setting changes were made.

I will repeat this with all plugins removed, and with IA only.

Did you restart your server or at least used /iareload between these changes? Feel free to open a private ticket (even if it's not a payment related issue) and ping me so that we can discuss more

purejosh commented 2 years ago

Yes, I restarted between all setting changes that were made. I'll open a ticket.

100petr commented 11 months ago

Hi, I have this problem too. Can I write here or do I have to start a new issue? disable-REAL_WIRE: false And it still says Tripwires are disabled on this server. In /config/paper-global.yml I have disable-tripwire-updates: false I will update the IA for tomorrow, but it probably won't affect it

image

LoneDev6 commented 11 months ago

It's impossible as the events system about custom blocks is not loaded at all when disable-REAL_WIRE: true. Are you using the property with inverted value? You must set it to true if you want to disable the blocks, not to false.

100petr commented 11 months ago

But I want to enable placing a vanilla tripwirehook with string as shown in the image in the first post image

LoneDev6 commented 11 months ago

You can't have real wire blocks and vanilla tripwire working at the same time.