search

PluginBugs / Issues-ItemsAdder

Repository used to keep track of issues of my plugin ItemsAdder
https://itemsadder.devs.beer
55 stars 21 forks source link

Issue with multiple armor textures #2176

Closed jere62smi closed 1 year ago

jere62smi commented 1 year ago

Terms

Discord tag (optional)

jere62smi#2156

What happened?

Hello,

I allow myself to send you contact via github because I have not found a way to find how to make a ticket on the Discord but only ItemsAdder-communities but I have no answer.

So here it is, I try to add several armors but when I add a second, or more I encounter an error with my texturepack, it works. The problem is that the texture worn by the player does not work and applies the colors given in color: "#fffff0".

In my configuration, only the armor named "kraken_set" and all its related items work As you can see, the one if works correctly, whether it's in the inventory as worn by a player.

Here is an armor where I have the problem, on the screen, I have my 2 textures in the correct inventory, on the other hand if I have worn it, I have the color of the leather armor entered in the config file.

I tried to find on the wiki or others how to add several armors in configuration, I must surely have made a mistake, if you could help me and explain me 🙂

I posted screens below of a texture that works correctly (inventory + player) and another that does not work (inventory + player).

I remain available on Discord in pm if you ever need more information or directly come to my test server to show you the problem encountered.

Steps to reproduce the issue

If I add an extra argument other than my_armor, I get the error and the texture problem.

my_armor: color: "#d60000" layer_1: kraken_set layer_2: kraken_set_2 use_color: false my_armor2: color: "#ffffff" layer_1: king_chestplate use_color: false my_armor3: color: "#fffff0" layer_1: noel_set use_color: false

Server version

git-Purpur-1857 (MC 1.19.2)

ItemsAdder Version

ItemsAdder 3.2.5-r3

ProtocolLib Version

ProtocolLib 5.0.0-SNAPSHOT-b602

LoneLibs Version

LoneLibs 1.0.21

LightAPI Version (optional)

No response

LibsDisguises Version (optional)

No response

FULL server log

No response

Error (optional)

[20:02:40] [Server thread/INFO]: jere62smi issued server command: /iazip
[20:02:40] [Server thread/INFO]: [ItemsAdder] [Pack] Extracting utility resource_pack assets from .jar
[20:02:40] [Server thread/INFO]: [ItemsAdder] [Pack] DONE extracting utility resource_pack assets from .jar
[20:02:40] [Craft Scheduler Thread - 42 - ItemsAdder/INFO]: [ItemsAdder] Loaded 229 items
[20:02:40] [Craft Scheduler Thread - 42 - ItemsAdder/INFO]: [ItemsAdder] Used 0/188 REAL block IDs
[20:02:40] [Craft Scheduler Thread - 42 - ItemsAdder/INFO]: [ItemsAdder] Used 29/750 REAL_NOTE block IDs
[20:02:40] [Craft Scheduler Thread - 42 - ItemsAdder/INFO]: [ItemsAdder] Used 0/63 REAL_TRANSPARENT block IDs
[20:02:40] [Craft Scheduler Thread - 42 - ItemsAdder/INFO]: [ItemsAdder] Used 0/127 REAL_WIRE block IDs
[20:02:40] [Craft Scheduler Thread - 42 - ItemsAdder/INFO]: [ItemsAdder] Used 0/14 FIRE block IDs
[20:02:40] [Craft Scheduler Thread - 42 - ItemsAdder/INFO]: [ItemsAdder] Used 699/6608 font_images
[20:02:40] [Craft Scheduler Thread - 42 - ItemsAdder/INFO]: [ItemsAdder] [Init] Loaded 5 categories
[20:02:40] [Craft Scheduler Thread - 42 - ItemsAdder/INFO]: [ItemsAdder] [Init] Loaded 229 items and stuff in 225ms
[20:02:40] [Server thread/INFO]: [PlaceholderAPI] Successfully registered expansion: img [1.0.1]
[20:02:40] [Server thread/INFO]: [PlaceholderAPI] Successfully registered expansion: iaplayerstat [1.0.1]
[20:02:40] [Server thread/INFO]: [EvenMoreFish] Detected that itemsadder has finished loading all items...
[20:02:40] [Server thread/INFO]: [EvenMoreFish] Reloading EMF.
[20:02:40] [Server thread/INFO]: [ItemsAdder] Reloading ItemsAdder Custom Entities Citizens NPCs
[20:02:40] [Craft Scheduler Thread - 42 - ItemsAdder/WARN]: java.lang.ArrayIndexOutOfBoundsException: Coordinate out of bounds!
[20:02:40] [Craft Scheduler Thread - 42 - ItemsAdder/WARN]:     at java.desktop/sun.awt.image.IntegerInterleavedRaster.setDataElements(IntegerInterleavedRaster.java:298)
[20:02:40] [Craft Scheduler Thread - 42 - ItemsAdder/WARN]:     at java.desktop/java.awt.image.BufferedImage.setRGB(BufferedImage.java:1017)
[20:02:40] [Craft Scheduler Thread - 42 - ItemsAdder/WARN]:     at ItemsAdder_3.2.5-r3.jar//dev.lone.itemsadder.main.ha.a(SourceFile:481)
[20:02:40] [Craft Scheduler Thread - 42 - ItemsAdder/WARN]:     at ItemsAdder_3.2.5-r3.jar//dev.lone.itemsadder.main.ha.a(SourceFile:382)
[20:02:40] [Craft Scheduler Thread - 42 - ItemsAdder/WARN]:     at ItemsAdder_3.2.5-r3.jar//dev.lone.itemsadder.main.ha.cr(SourceFile:244)
[20:02:40] [Craft Scheduler Thread - 42 - ItemsAdder/WARN]:     at ItemsAdder_3.2.5-r3.jar//dev.lone.itemsadder.main.hn.cD(SourceFile:418)
[20:02:40] [Craft Scheduler Thread - 42 - ItemsAdder/WARN]:     at ItemsAdder_3.2.5-r3.jar//dev.lone.itemsadder.main.aA.a(SourceFile:2607)
[20:02:40] [Craft Scheduler Thread - 42 - ItemsAdder/WARN]:     at ItemsAdder_3.2.5-r3.jar//dev.lone.itemsadder.main.au.a(SourceFile:91)
[20:02:40] [Craft Scheduler Thread - 42 - ItemsAdder/WARN]:     at ItemsAdder_3.2.5-r3.jar//dev.lone.itemsadder.main.aA.a(SourceFile:2407)
[20:02:40] [Craft Scheduler Thread - 42 - ItemsAdder/WARN]:     at org.bukkit.craftbukkit.v1_19_R1.scheduler.CraftTask.run(CraftTask.java:101)
[20:02:40] [Craft Scheduler Thread - 42 - ItemsAdder/WARN]:     at org.bukkit.craftbukkit.v1_19_R1.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:57)
[20:02:40] [Craft Scheduler Thread - 42 - ItemsAdder/WARN]:     at com.destroystokyo.paper.ServerSchedulerReportingWrapper.run(ServerSchedulerReportingWrapper.java:22)
[20:02:40] [Craft Scheduler Thread - 42 - ItemsAdder/WARN]:     at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
[20:02:40] [Craft Scheduler Thread - 42 - ItemsAdder/WARN]:     at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
[20:02:40] [Craft Scheduler Thread - 42 - ItemsAdder/WARN]:     at java.base/java.lang.Thread.run(Thread.java:833)
[20:02:40] [Server thread/INFO]: [Mythic] Reloading plugin...
[20:02:40] [Server thread/INFO]: [MythicMobs] Mythic beginning reload procedure...
[20:02:40] [Server thread/INFO]: [MythicMobs] Loading Packs...
[20:02:40] [Server thread/INFO]: [MythicMobs] Loading Items...
[20:02:40] [Craft Scheduler Thread - 42 - ItemsAdder/INFO]: [ItemsAdder] [OK] Your zip file will be protected from unzip (as set in config.yml)
[20:02:40] [Server thread/INFO]: [MythicMobs] Loading Item Groups...
[20:02:40] [Server thread/INFO]: [MythicMobs] Loading Skills...
[20:02:41] [Server thread/INFO]: [MythicMobs] Loading Drop Tables...
[20:02:41] [Server thread/INFO]: [MythicMobs] Loading Random Spawns...
[20:02:41] [Server thread/INFO]: [MythicMobs] Loading Spawn Blocks...
[20:02:41] [Server thread/INFO]: [MythicMobs] ✓ Loaded 148 mobs.
[20:02:41] [Server thread/INFO]: [MythicMobs] ✓ Loaded 0 vanilla mob overrides.
[20:02:41] [Server thread/INFO]: [MythicMobs] ✓ Loaded 0 mob stacks.
[20:02:41] [Server thread/INFO]: [MythicMobs] ✓ Loaded 388 skills.
[20:02:41] [Server thread/INFO]: [MythicMobs] ✓ Loaded 0 random spawns.
[20:02:41] [Server thread/INFO]: [MythicMobs] ✓ Loaded 120 mythic items.
[20:02:41] [Server thread/INFO]: [MythicMobs] ✓ Loaded 0 drop tables.
[20:02:41] [Server thread/INFO]: [MythicMobs] ✓ Loaded 213 mob spawners.
[20:02:41] [Server thread/INFO]: [Mythic] Mythic has finished reloading!
[20:02:41] [Server thread/INFO]: [MythicMobs] Mythic has finished reloading!
[20:02:41] [Craft Scheduler Thread - 42 - ItemsAdder/INFO]: [ItemsAdder] [Pack] Compressing resource_pack ... 
[20:02:41] [Craft Scheduler Thread - 42 - ItemsAdder/INFO]: [ItemsAdder] [Pack] Resource pack successfully compressed. Uploading...
[20:02:41] [Craft Scheduler Thread - 42 - ItemsAdder/INFO]: [ItemsAdder] [Pack] Uploading resourcepack...
[20:02:43] [Craft Scheduler Thread - 42 - ItemsAdder/INFO]: [ItemsAdder] [Pack] Finished uploading resourcepack: http://resourcepack.host/dl/D4evETDAdZTTrgpZNQy1XivrlJMGicWL/pack.zip
[20:02:53] [Craft Scheduler Thread - 42 - ItemsAdder/INFO]: [ItemsAdder] [Pack] Resourcepack URL is valid (auto-external-host), LastEdit: 2022-12-11_20-02. Url: http://resourcepack.host/dl/D4evETDAdZTTrgpZNQy1XivrlJMGicWL/pack.zip
[20:02:53] [Craft Scheduler Thread - 42 - ItemsAdder/INFO]: [ItemsAdder] Applying pack to every player... 
[20:02:53] [Craft Scheduler Thread - 42 - ItemsAdder/INFO]: [ItemsAdder] Applied pack to 1 players

ItemsAdder config.yml

metrics: false
update-checker: true
disable-plugin-loading-messages_DONT_ASK_ME_FOR_SUPPORT_IF_YOU_SET_TRUE__THANKS: false
resource-pack:
  hosting:
    no-host:
      enabled: false
    auto-external-host:
      enabled: true
    self-host:
      enabled: false
      server-ip: 127.0.0.1
      pack-port: 8163
    external-host:
      enabled: false
      url: https://drive.google.com/uc?export=view&id=1SlGvV4SZzsB43rGAtGZsgcpxI0s33fWQ
      skip-url-file-type-check___DONT_ASK_HELP_IF_SET_TRUE: false
  apply-on-join: true
  kick-player-on-decline: true
  kick-player-on-fail: true
  delay-ticks: 1
  notify-other-plugins-interfering: true
  title:
    enabled: true
  protect-player:
    black-screen: true
    hide-hud: true
    cancel-movement: true
    lock-player: true
  command:
    usage-cooldown-seconds: 60
  custom-font:
    enabled: false
    name: ipaexg.ttf
    shift: '[0,0]'
    size: 11.0
    oversample: 2.0
  thin-font:
    enabled: false
  zip:
    protect-file-from-unzip:
      protection_1: true
      protection_2: true
    compress-png-files: true
    compress-json-files: true
    generate-custom-armors-textures:
      vanilla_1_17: true
      optifine: true
    disable-overwrite-leather-armor-layers-textures: false
    ignore-files-ext:
    - db
    - yml
    - xcf
    - psd
    - html
    - gz
    - rar
    - zip
    - 7z
    - bbmodel
    - iaentitymodel
    fix_transparent_noteblocks: false
    contents-folders-priority:
    - vanilla
    - _iainternal
    overwrite-vanilla-models: false
    overwrite-vanilla-lang-json: false
    fix_transparent_noteblocks__disable-for-more-performance: false
  items:
    CustomModelData-starting-value:
      ALL: 10000
      DIAMOND: 11000
config_files:
  lang: en
  dictionaries-lang: en
  extract-default-resources: false
  force-sync-loading: false
  extract-default-configs: true
  legacy_pack: false
blocks:
  light-api: true
  fix-liquids-flow: true
  fix-floating-blocks: true
  fix-glitched-blocks:
    enabled: true
    only-new-chunks: false
  cancel-break-wrong-tool:
    enabled: true
    send-actionbar: true
  campfire:
    unlit-on-place: true
    allow-any-item: true
  disable-REAL: false
  disable-REAL_TRANSPARENT: false
  disable-REAL_NOTE: false
  disable-REAL_WIRE: true
  disable-FIRE: false
  convert-vanilla-blocks:
    enabled: false
    only-new-chunks: true
items:
  fix-show-attack-and-damage-as-lore: true
  give_death_location_maps: true
  hide-custom-durability-lore: false
liquids:
  enabled: true
huds:
  enabled: true
loots:
  allow-loots-drop-from-spawners-using-silk-touch: false
mobs:
  disable-MOB-behaviour__DISABLE_AT_YOUR_OWN_RISK: false
font_images:
  replace-in-customitems-name-and-lore: true
  chat:
    enabled: true
    doublecheck-permission__disable-for-more-performance: false
    add-hover-suggestion: true
  command:
    enabled: true
    commandblocks: true
    excluded:
    - home
    - sethome
    - tpa
  sign:
    enabled: true
  book:
    enabled: true
  anvil:
    enabled: true
  inventory-title:
    enabled: true
  vault-prefix-suffix:
    enabled: true
    update-every-ticks: 1200
  scoreboard-teams:
    enabled: false
    update-every-ticks: 3600
  player-display-name:
    enabled: true
    update-every-ticks: 1200
effects:
  hide-scoreboard-numbers: true
  text-effects:
    enabled: true
    replace-in-customitems-name-and-lore: true
    chat:
      enabled: true
    sign:
      enabled: true
    book:
      enabled: true
    anvil:
      enabled: true
entities:
  max-furniture-vehicles-per-chunk: 30
  allow-removing-old-furnitures_2_3_11: false
  custom-entitites:
    enabled: true
    interval-rendering-packets-ticks: 1
    emotes: false
    optimized-packets: true
recipes:
  hide-vanilla-unrecognized-recipe-errors: true
  fix-packet-too-large-kick: false
  custom-recipes:
    unlock:
      all-on-join: false
      on-pickup:
        any: false
        ingredients: true
  remove-vanilla-recipes:
    enabled: true
    list:
      DIAMOND_SWORD: false
      IRON_INGOT: false
debug:
  items:
    log-files-loading: false
    log-items-loading: false
    log-items-loading-disabled: false
    log-font-images-loading: false
    log-huds-loading: false
    log-attribute-modifiers-loading: false
    log-warnings: false
    log-loots-loading: false
    log-loots-loading-disabled: false
    log-armors-loading: false
  recipes:
    log-recipes-loading: false
    log-recipes-loading-disabled: false
    log-recipes-removed-vanilla: false
    log-fix-packet-too-large: false
    log-recipes-unknown-item: false
  resource-pack:
    log-extract-default-resources: false
    log-not-extract-default-resources-already-exist: false
  blocks:
    log-save: false
    log-save-on-unload: false
    log-mined-unknown-blocks: true
    log-convert-vanilla-blocks: false
  worlds-populators:
    log-loading: false
    log-loading-disabled: false
    log-loading-no-populators: false
    log-loading-no-world: false
    log-generation: false
  trees-populators:
    log-loading: false
    log-loading-disabled: false
    log-loading-no-populators: false
    log-loading-no-world: true
    log-generation: false
  surface-decorators:
    log-loading: false
    log-loading-disabled: false
    log-loading-no-decorators: false
    log-loading-no-world: true
    log-generation: false
  player-stats:
    log-save: false
  performance:
    loading-ms: true
  huds:
    log-triggers: false
  other:
    log-dictionaries-loading: false
    log-liquids-loading: false
    log-minecraft_lang_overwrite-loading: false
  categories:
    log-total-loaded: true
    log-single-loaded: true
    log-single-loaded-overwrite: true
    log-single-skip: true
    log-icon-failed-load: false
  entities:
    log-files-loading: false
    log-entities-loading: false
    log-entities-loading-disabled: false
  cave-decorators:
    log-loading: false
    log-loading-disabled: false
    log-loading-no-decorators: false
    log-loading-no-world: true
    log-generation: false
chat-preview: false
ignore-server-compatibility-check: false

Problematic items yml configuration file (optional)

info:
  namespace: rpg
armors_rendering:
  my_armor:
    color: "#d60000"
    layer_1: kraken_set
    layer_2: kraken_set_2
    use_color: false
  my_armor2:
    color: "#ffffff"
    layer_1: king_chestplate
    use_color: false
  my_armor3:
    color: "#fffff0"
    layer_1: noel_set
    use_color: false
items:
  king_sword:
    display_name: Epée du Vieux Roi
    resource:
      material: golden_sword
      model_id: 10300
      generate: true
      textures: 
      - king_sword.png
  faux:
    display_name: Faux de la Faucheuse
    resource:
      material: iron_hoe
      model_id: 10302
      generate: true
      textures: 
      - faux.png
  bone_dague:
    display_name: Os du Gardien
    resource:
      material: iron_sword
      model_id: 10303
      generate: true
      textures: 
      - bone_dague.png
  guardian_shield:
    display_name: Carapace du Gardien
    resource:
      material: SHIELD
      model_id: 10304
      generate: true
      textures: 
      - guardian_shield.png
  pirate_sword:
    display_name: Epée du Pirate
    resource:
      material: diamond_sword
      model_id: 10301
      generate: false
      model_path: pirate_sword
  ogre_mace:
    display_name: Masse de l'Ogre
    resource:
      material: diamond_sword
      model_id: 10305
      generate: false
      model_path: ogre_mace
  baguette:
    display_name: Baguette de GuerreCendre
    resource:
      material: stick
      model_id: 10306
      generate: false
      model_path: baguette
#casque kraken
  kraken_hat:
    display_name: Casque du Kraken
    resource:
      model_id: 10307
      generate: true
      textures:
      - kraken_hat
    mmoitem:
      type: ARMOR
      id: CASQUE_KRAKEN
    specific_properties:
      armor:
        slot: head
        custom_armor: my_armor
#plastron kraken
  kraken_chestplate_item:
    display_name: Plastron du Kraken
    resource:
      model_id: 10308
      generate: true
      textures:
      - kraken_chestplate_item
    mmoitem:
      type: ARMOR
      id: PLASTRON_KRAKEN
    specific_properties:
      armor:
        slot: chest
        custom_armor: my_armor
#jambière kraken
  kraken_pants:
    display_name: Jambière du Kraken
    resource:
      model_id: 10309
      generate: true
      textures:
      - kraken_pants
    mmoitem:
      type: ARMOR
      id: JAMBIERE_KRAKEN
    specific_properties:
      armor:
        slot: legs
        custom_armor: my_armor
#bottes kraken
  kraken_boots:
    display_name: Bottes du Kraken
    resource:
      model_id: 10310
      generate: true
      textures:
      - kraken_boots
    mmoitem:
      type: ARMOR
      id: BOTTES_KRAKEN
    specific_properties:
      armor:
        slot: feet
        custom_armor: my_armor
  # plastron vieux roi
  king_chestplate:
    display_name: Plastron du Vieux Roi
    resource:
      model_id: 10311
      generate: true
      textures:
      - king_chestplate_item
    mmoitem:
      type: ARMOR
      id: VIEUX_ROI
    specific_properties:
      armor:
        slot: chest
        custom_armor: my_armor2
#bottes noel
  noel_boots:
    display_name: Bottes de Noel
    resource:
      model_id: 10312
      generate: true
      textures:
      - noel_boots
    specific_properties:
      armor:
        slot: feet
        custom_armor: my_armor3
#jambière noel
  noel_pants:
    display_name: Jambière de Noel
    resource:
      model_id: 10313
      generate: true
      textures:
      - noel_pants
    specific_properties:
      armor:
        slot: legs
        custom_armor: my_armor3

Other files, you can drag and drop them here to upload. (optional)

No response

Screenshots/Videos (you can drag and drop files or paste links)

image1 image2

LoneDev6 commented 1 year ago

Provide a valid ItemsAdder rconfigurations + resources folder for me to load it into my server and test. I cannot do tests with only the YML configuration.

Anyway you should make sure your armor textures have the correct size.

jere62smi commented 1 year ago

Hello, First of all, I would like to thank you for taking the time to answer and help me. Is it possible that you send me a Discord message or other networks to send you my configuration files and avoid sharing them for everyone. The configuration to test is located in: data/items_packs/rpg/rpg.yml Textures in pgn format can be found in data/resource_pack/assets/rpg Looking forward to your return.

LoneDev6 commented 1 year ago

No worries, i wish i had more time to answer everyone. Open a private ticket on my Discord server even if it's not a payment issue and kindly attach this issue report link so staff knows what's about.

Thanks

LoneDev6 commented 1 year ago

Some of your armors are missing layer_2. Use a blank 64x32 image or actually create the layer_2 image for these armors.

I copied the first layer_2 to each other armor in order to test this out and it works fine.

armors_rendering:
  my_armor:
    color: "#d60000"
    layer_1: kraken_set
    layer_2: kraken_set_2
    use_color: false
  my_armor2:
    color: "#ffffff"
    layer_1: king_chestplate
    layer_2: kraken_set_2
    use_color: false
  my_armor3:
    color: "#fffff0"
    layer_1: noel_set
    layer_2: kraken_set_2
    use_color: false

image