PluginBugs / Issues-ItemsAdder

Repository used to keep track of issues of my plugin ItemsAdder
https://itemsadder.devs.beer
55 stars 21 forks source link

Vanilla blocks not breaking sometimes when mining fast #4076

Open Borplesnoots opened 1 month ago

Borplesnoots commented 1 month ago

Terms

Discord Username (optional)

borplesnoots

What happened?

When breaking any blocks, using vanilla enchants - the blocks do not break as expected. This makes any sort of gameplay immediately annoying when breaking blocks. For example, a netherite pickaxe with Eff 5 and haste 2 can easily break ~2-3 blocks when walking back and forth, but when ItemsAdder is on the server there will be blocks intermittently left behind. This is replicatable with anything, e.g. shovel with dirt, sand, etc.

image

With ItemsAdder and dependencies

Without ItemsAdder (zero plugins on server): Without ItemsAdder

No other plugins are on the server. I was able to replicate this also on 1.21.1

This was reported in #3835 as "minor", and you stated there was no solution however this has large implications over the ability for any server owner to use ItemsAdder on their server, as this is largely a block breaking game.

Steps to reproduce the issue

  1. Mine any blocks quickly enough. Either with instant-break blocks like flowers/grass, or with high enough efficiency/haste for other blocks
  2. Notice that not all blocks are breaking as expected

Server version

This server is running Paper version 1.21-130-master@b1b5d4c (2024-08-10T10:02:42Z) (Implementing API version 1.21-R0.1-SNAPSHOT)

ItemsAdder Version

4.0.2-beta-release-12

ProtocolLib Version

5.3.0

LoneLibs Version

1.0.59

Full Server Log

https://mclo.gs/vsO7NT6

Error (optional)

No response

Problematic items yml configuration file (optional)

No response

Other files, you can drag and drop them here to upload. (optional)

No response

Screenshots/Videos (you can drag and drop files or paste links)

No response

Borplesnoots commented 1 month ago

Tested and issue is still present in ItemsAdder Version 4.0.3, ProtocolLib Version 5.3.0, and LoneLibs Version 1.0.59

LoneDev6 commented 1 week ago

Thank you for the very detailed test. I will check this as soon as possible for a possible mitigation of the issue.

LoneDev6 commented 4 days ago

Testing with netherite pickaxe with efficiency 5, haste 2 and speed 2. It's related to latency, will find a way to fix that issue. NOTE: It's different from #3835 as the other issue refers to particle not being played, which is caused by the current issue probably.

Tested with 200+ ping - ItemsAdder NOT installed

https://github.com/user-attachments/assets/beac989d-a5b5-4fbc-aa91-059f5bfaf6a6

Tested with 200+ ping - ItemsAdder installed

https://github.com/user-attachments/assets/d18ca5ac-01e0-46d0-aac4-a017b2f162f3

LoneDev6 commented 4 days ago

@borplesnoots can you please join the Discord server again in order to test the new beta version? I should have mitigated the issue completely.

Borplesnoots commented 4 days ago

@Borplesnoots can you please join the Discord server again in order to test the new beta version? I should have mitigated the issue completely.

Awesome! I've rejoined.