Move Improv announcement from setup to loop

[rbergen]

Description

This fixes #596, which documents a case where the sending of the Improv state packet to indicate we're up blocks setup, and hence the starting of the blinking of LEDs. It does this by moving the one-time sending of the packet from ImprovSerial::setup() to ImprovSerial::loop().

Contributing requirements

• [x] I read the contribution guidelines in CONTRIBUTING.md.
• [x] I understand the BlinkenPerBit metric, and maximized it in this PR.
• [x] I selected main as the target branch.
• [x] All code herein is subjected to the license terms in COPYING.txt.

[robertlipe]

How does that block? The usart doesn't know there is a listener, does it?

Do we need to think about leaving improv for Espressif's own OTA?

On Thu, Jan 25, 2024, 2:55 AM Rutger van Bergen @.***> wrote:

Description

This fixes #596 https://github.com/PlummersSoftwareLLC/NightDriverStrip/issues/596, which documents a case where the sending of the Improv state packet to indicate we're up blocks setup, and hence the starting of the blinking of LEDs. It does this by moving the one-time sending of the packet from ImprovSerial::setup() to ImprovSerial::loop(). Contributing requirements

• I read the contribution guidelines in CONTRIBUTING.md https://github.com/PlummersSoftwareLLC/NightDriverStrip/blob/main/CONTRIBUTING.md .
• I understand the BlinkenPerBit metric, and maximized it in this PR.
• I selected main as the target branch.
• All code herein is subjected to the license terms in COPYING.txt https://github.com/PlummersSoftwareLLC/NightDriverStrip/blob/main/COPYING.txt .

---

You can view, comment on, or merge this pull request online at:

https://github.com/PlummersSoftwareLLC/NightDriverStrip/pull/599 Commit Summary

• 249d59a https://github.com/PlummersSoftwareLLC/NightDriverStrip/pull/599/commits/249d59a142b139604d47a8a7a36ad40b4b57d7ad Move Improv announcement from setup to loop

File Changes

(1 file https://github.com/PlummersSoftwareLLC/NightDriverStrip/pull/599/files)

• M include/improvserial.h https://github.com/PlummersSoftwareLLC/NightDriverStrip/pull/599/files#diff-da828e20e951d7ce172d4a6332e25087b35134c3798a2ae2cffde46c285553d8 (10)

Patch Links:

- https://github.com/PlummersSoftwareLLC/NightDriverStrip/pull/599.patch

• https://github.com/PlummersSoftwareLLC/NightDriverStrip/pull/599.diff

— Reply to this email directly, view it on GitHub https://github.com/PlummersSoftwareLLC/NightDriverStrip/pull/599, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCSD34F3P6RI5LNO3532HDYQIMXJAVCNFSM6AAAAABCKEHABGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA4TSOBYGI2DKNQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

[rbergen]

How does that block? The usart doesn't know there is a listener, does it?

I wouldn't expect it to, but who am I to make any definitive statements about it? In a USB context, at some point something does have to keep track of what's been sent and what hasn't. The extent to what that considers confirmation of reception I wouldn't dare to guess for all possible scenarios.

Do we need to think about leaving improv for Espressif's own OTA?

As far as I understand it, Espressif OTA concerns the delivery of updates over WiFi or Bluetooth. Improv (over serial) facilitates the functioning of the Web Installer, which I think really is a thing in itself. For one, it can be used to set up the WiFi that OTA could use.

[rbergen]

Merging after "regular operation" with the change has been confirmed on both Mesmerizer and M5StickC Plus/Spectrum.