PoE-Overlay-Community / PoE-Overlay-Community-Fork

An Overlay for Path of Exile. Built with Angular.
MIT License
459 stars 84 forks source link

Suggestion: Tier-aware bounds for affix values in evaluation and search. #268

Open BeliefDiviner opened 2 years ago

BeliefDiviner commented 2 years ago

Is your feature request related to a problem? Please describe. I'm constantly frustrated by the range of behaviours available to the Evaluate module regarding lower and upper bounds of mod values on items. Those bounds are not helpful when you are considering possible outcomes of divine orbs (beast/harvest value rerolls). For example, in the picture below, a ring has "of the Tempest" (tier 4) lightning resistance suffix, this suffix's value is rolled from the 30-35 range band.

image

When you evaluate the item, you get the default (-10%) lower bound on lightning resistance, 27, which is outside the possible rolls for that tier of resists.

image

This then pollutes trade search results with items that can never get to the modifier values this item can, which makes those results, in some cases, irrelevant for pricing. (Not with this ring, it's 1 alch, especially at this stage of the league. :P)

Describe the solution you'd like Add an option to automatically detect the tier of modifiers and set lower and/or upper bounds to that tier's minimum and maximum rolls respectively.

Describe alternatives you've considered Alternative is to do this manually for every search which is cumbersome.

Some implementation details

  1. This automatic detection should be jewelry quality independent, and can be done via mod value table lookup.
  2. Mod value tables can be acquired from PoE Wiki or PoEDB. Those tables are quite static, and rarely change, so updates for them, after initial download, can be queried during stage testing and/or release packaging.

Additional context If this proposition is accepted, I'd happily implement it myself.