fix(tagging): stop popup from dismissing while updating tags after save

collectedmind commented 4 years ago

Goal

Fix #65: popup closes while typing tags

Root cause

The root cause seems to be that upon tag input the cancel close request is not being called so once the timeout reaches the popup is closed even while the user is typing a tag.

Todos:

[x] Reproduce issue ( steps outlined in #65 )
[x] add a tag input focus action whenever input receives focus
[x] trigger cancel close request when input receives focus

Implementation Decisions

Approach

I decided to add a tag input focus action and saga that ensures cancel close request is explicitly triggered whenever the tag input receives focus.

All Submissions:

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

collectedmind commented 4 years ago

Opening this as a temporary record since #203 was automatically dismissed when develop was removed. Moving towards having a single source of truth and develop was an outdated convention.

anthony-liddle commented 3 years ago

Closing this PR as it is outdated and this issue has been resolved here: https://github.com/Pocket/extension-save-to-pocket/pull/229

Pocket / extension-save-to-pocket