bucket_game mkdir issue in Trolltest (execute)

[Poikilos]

Building trolltest and running bucket_game results in:

ModError: Failed to load and run script from /home/owner/trolltest-rsync/bin/../games/bucket_game/mods/codercore/ocsethome/init.lua:
...bin/../games/bucket_game/mods/codercore/ocmkdir/init.lua:21: attempt to call field 'execute' (a nil value)
stack traceback:
    ...bin/../games/bucket_game/mods/codercore/ocmkdir/init.lua:21: in function 'mkdir'
    ...n/../games/bucket_game/mods/codercore/ocsethome/init.lua:36: in main chunk
Check debug.txt for details.

Related to:

• 613

Solutions:

• Use minetest.mkdir added ~2015 (if minetest.mkdir then): https://github.com/minetest/minetest/issues/3132

[mckaygerhard]

why a lua MOD script must call "mkdir" ? an I/O operation its so invasive

[Poikilos]

I can make a patch to affected mods using get_mod_storage

[Poikilos]

mkdir_patches-vs-mtkit-230820.zip WIP patches (tested and working in our build of trolltest 5.3-dev) mkdir_patches-vs-mtkit-230820.zip If you have trouble patching, read the patches in a text editor. You should be able to make the change by hand if necessary. It uses the following workaround which is common to make mods backward compatible but not require disabling mod security on any minetest that has minetest.mkdir (circa 2015):

        if  minetest.mkdir then
            minetest.mkdir(dir)
        else
            os.execute('mkdir "'..dir..'"')
        end

[mckaygerhard]

could we provide a new release of bucket game in downloads? for confortability of users you know it?

[Poikilos]

OldCoder is testing the patches.

[mckaygerhard]

this issue is already fixed with such patches, i will report the rest cos such patch are only for mkdir issue, this i pretty obvious

[Poikilos]

Fix for 240107 master copy, and patch out of ocsethome (change to player metadata) as well

no_unsafe_calls_ocmkdir_and_ocsethome-vs-bucket_game-master-240106.zip

or

no_unsafe_calls_ocmkdir_and_ocsethome-vs-bucket_game-master-240106.patch