Pointcept / SegmentAnything3D

[ICCV'23 Workshop] SAM3D: Segment Anything in 3D Scenes
https://arxiv.org/abs/2306.03908
MIT License
1.02k stars 70 forks source link

Is this line redundant? #11

Closed LinLin1031 closed 1 year ago

LinLin1031 commented 1 year ago

https://github.com/Pointcept/SegmentAnything3D/blob/0c785ea0b6796181153605cb07650b34ac4f531b/sam3d.py#LL62C1-L62C54

Hello!

During debugging, I found that the shape of the "mask" array here is (240, 320), but this line of code changed the shape of the "color_image" data to (640, 480), making the "color_image[mask]" have the wrong dimension. By annotating this line of code, we can avoid this error. So is it redundant?

LinLin1031 commented 1 year ago

@Gofinge @yhyang-myron Hope to hear from you soon, thanks!