search

Pointcept / SegmentAnything3D

[ICCV'23 Workshop] SAM3D: Segment Anything in 3D Scenes
https://arxiv.org/abs/2306.03908
MIT License
1.02k stars 70 forks source link

fix: Improve speed of kdtree grouping by pointops #46

Closed small-zeng closed 7 months ago

small-zeng commented 7 months ago

Thanks for your nice work.

When the point count is too large, CPU loop querying for the nearest points becomes too slow. It is recommended to switch to point operations querying

yhyang-myron commented 7 months ago

Thank you for interest in our work and pull request! I notice that the function _get_matchingindices is missing a return.

small-zeng commented 7 months ago

Thank you for interest in our work and pull request! I notice that the function _get_matchingindices is missing a return.

Sorry，I have added it

yhyang-myron commented 7 months ago

I tried it on scene0000_00, but met an IndexError: at here, index 3007 is out of bounds for axis 0 with size 3005.

small-zeng commented 7 months ago

I tried it on scene0000_00, but met an IndexError: at here, index 3007 is out of bounds for axis 0 with size 3005.

I check it, and the problem is 186 line in sam3d.py, it is modified.

image

small-zeng commented 7 months ago

I tried it on scene0000_00, but met an IndexError: at here, index 3007 is out of bounds for axis 0 with size 3005. The code is copied from another project, so something can be missing

small-zeng commented 7 months ago

I tried it on scene0000_00, but met an IndexError: at here, index 3007 is out of bounds for axis 0 with size 3005.

Thank you, I try this modified code, there is no error. image

yhyang-myron commented 7 months ago

Thank you !