Open ByThePowerOfScience opened 1 month ago
Looking over other mods' Githubs (ie, Alex's Caves, Occultism), they looked to be registering their Particles on their mod's main constructor. My guess is, judging by the snippet given, the issue is caused by com.Polarice3.Goety.client.particles.WindBlowParticle initialization. I will have to look into this.
Can you check if it still crashes as of the latest update? Works fine when I tested it.
Can you check if it still crashes as of the latest update? Works fine when I tested it.
It doesn't crash, it just prevents some other registry events from other mods from completing due to the classload error. That's what causes a crash.
Issue still occurs on Goety - 2.5.33.3:
Does it happen with any other mods like Alex's Caves? Cause have no clue why my mod's the only thing making the whole thing funky
Mod Loader
Forge 1.20.1 - 47.4.0
Mod version
Goety 2.5.33.1
Issue description
The ModParticleTypes and other client-side registries are run in the
Goety
constructor regardless of the side the mod's being run on, causing the events to fail and potentially messing with other mods' registration events. Just add a check for if side == client before running their registries.Link or Post Log Files
Relevant snippet
``` 06.05 17:43:24 [Server] main/ERROR [ne.mi.fm.lo.RuntimeDistCleaner/DISTXFORM]: Attempted to load class net/minecraft/client/particle/Particle for invalid dist DEDICATED_SERVER 06.05 17:43:24 [Server] main/ERROR [ne.mi.ev.EventSubclassTransformer/EVENTBUS]: An error occurred building event handler 06.05 17:43:24 [Server] INFO java.lang.RuntimeException: Attempted to load class net/minecraft/client/particle/Particle for invalid dist DEDICATED_SERVER 06.05 17:43:24 [Server] INFO at net.minecraftforge.fml.loading.RuntimeDistCleaner.processClassWithFlags(RuntimeDistCleaner.java:57) ~[fmlloader-1.20.1-47.4.0.jar%2369!/:1.0] {} 06.05 17:43:24 [Server] INFO at cpw.mods.modlauncher.LaunchPluginHandler.offerClassNodeToPlugins(LaunchPluginHandler.java:88) ~[modlauncher-10.0.9.jar%2355!/:?] {} 06.05 17:43:24 [Server] INFO at cpw.mods.modlauncher.ClassTransformer.transform(ClassTransformer.java:120) ~[modlauncher-10.0.9.jar%2355!/:?] {} 06.05 17:43:24 [Server] INFO at cpw.mods.modlauncher.TransformingClassLoader.maybeTransformClassBytes(TransformingClassLoader.java:50) ~[modlauncher-10.0.9.jar%2355!/:?] {} 06.05 17:43:24 [Server] INFO at cpw.mods.cl.ModuleClassLoader.readerToClass(ModuleClassLoader.java:113) ~[securejarhandler-2.1.10.jar:?] {} 06.05 17:43:24 [Server] INFO at cpw.mods.cl.ModuleClassLoader.lambda$findClass$15(ModuleClassLoader.java:219) ~[securejarhandler-2.1.10.jar:?] {} 06.05 17:43:24 [Server] INFO at cpw.mods.cl.ModuleClassLoader.loadFromModule(ModuleClassLoader.java:229) ~[securejarhandler-2.1.10.jar:?] {} 06.05 17:43:24 [Server] INFO at cpw.mods.cl.ModuleClassLoader.findClass(ModuleClassLoader.java:219) ~[securejarhandler-2.1.10.jar:?] {} 06.05 17:43:24 [Server] INFO at cpw.mods.cl.ModuleClassLoader.loadClass(ModuleClassLoader.java:135) ~[securejarhandler-2.1.10.jar:?] {} 06.05 17:43:24 [Server] INFO at java.lang.ClassLoader.loadClass(ClassLoader.java:525) ~[?:?] {} 06.05 17:43:24 [Server] INFO at net.minecraftforge.eventbus.EventSubclassTransformer.buildEvents(EventSubclassTransformer.java:97) ~[eventbus-6.0.5.jar%2352!/:?] {} 06.05 17:43:24 [Server] INFO at net.minecraftforge.eventbus.EventSubclassTransformer.transform(EventSubclassTransformer.java:48) ~[eventbus-6.0.5.jar%2352!/:?] {} 06.05 17:43:24 [Server] INFO at net.minecraftforge.eventbus.EventBusEngine.processClass(EventBusEngine.java:26) ~[eventbus-6.0.5.jar%2352!/:?] {} 06.05 17:43:24 [Server] INFO at net.minecraftforge.eventbus.service.ModLauncherService.processClassWithFlags(ModLauncherService.java:32) ~[eventbus-6.0.5.jar%2352!/:6.0.5+6.0.5+master.eb8e549b] {} 06.05 17:43:24 [Server] INFO at cpw.mods.modlauncher.LaunchPluginHandler.offerClassNodeToPlugins(LaunchPluginHandler.java:88) ~[modlauncher-10.0.9.jar%2355!/:?] {} 06.05 17:43:24 [Server] INFO at cpw.mods.modlauncher.ClassTransformer.transform(ClassTransformer.java:120) ~[modlauncher-10.0.9.jar%2355!/:?] {} 06.05 17:43:24 [Server] INFO at cpw.mods.modlauncher.TransformingClassLoader.maybeTransformClassBytes(TransformingClassLoader.java:50) ~[modlauncher-10.0.9.jar%2355!/:?] {} 06.05 17:43:24 [Server] INFO at cpw.mods.cl.ModuleClassLoader.readerToClass(ModuleClassLoader.java:113) ~[securejarhandler-2.1.10.jar:?] {} 06.05 17:43:24 [Server] INFO at cpw.mods.cl.ModuleClassLoader.lambda$findClass$15(ModuleClassLoader.java:219) ~[securejarhandler-2.1.10.jar:?] {} 06.05 17:43:24 [Server] INFO at cpw.mods.cl.ModuleClassLoader.loadFromModule(ModuleClassLoader.java:229) ~[securejarhandler-2.1.10.jar:?] {} 06.05 17:43:24 [Server] INFO at cpw.mods.cl.ModuleClassLoader.findClass(ModuleClassLoader.java:219) ~[securejarhandler-2.1.10.jar:?] {} 06.05 17:43:24 [Server] INFO at cpw.mods.cl.ModuleClassLoader.loadClass(ModuleClassLoader.java:135) ~[securejarhandler-2.1.10.jar:?] {} 06.05 17:43:24 [Server] INFO at java.lang.ClassLoader.loadClass(ClassLoader.java:525) ~[?:?] {} 06.05 17:43:24 [Server] INFO at net.minecraftforge.eventbus.EventSubclassTransformer.buildEvents(EventSubclassTransformer.java:97) ~[eventbus-6.0.5.jar%2352!/:?] {} 06.05 17:43:24 [Server] INFO at net.minecraftforge.eventbus.EventSubclassTransformer.transform(EventSubclassTransformer.java:48) ~[eventbus-6.0.5.jar%2352!/:?] {} 06.05 17:43:24 [Server] INFO at net.minecraftforge.eventbus.EventBusEngine.processClass(EventBusEngine.java:26) ~[eventbus-6.0.5.jar%2352!/:?] {} 06.05 17:43:24 [Server] INFO at net.minecraftforge.eventbus.service.ModLauncherService.processClassWithFlags(ModLauncherService.java:32) ~[eventbus-6.0.5.jar%2352!/:6.0.5+6.0.5+master.eb8e549b] {} 06.05 17:43:24 [Server] INFO at cpw.mods.modlauncher.LaunchPluginHandler.offerClassNodeToPlugins(LaunchPluginHandler.java:88) ~[modlauncher-10.0.9.jar%2355!/:?] {} 06.05 17:43:24 [Server] INFO at cpw.mods.modlauncher.ClassTransformer.transform(ClassTransformer.java:120) ~[modlauncher-10.0.9.jar%2355!/:?] {} 06.05 17:43:24 [Server] INFO at cpw.mods.modlauncher.TransformingClassLoader.maybeTransformClassBytes(TransformingClassLoader.java:50) ~[modlauncher-10.0.9.jar%2355!/:?] {} 06.05 17:43:24 [Server] INFO at cpw.mods.cl.ModuleClassLoader.readerToClass(ModuleClassLoader.java:113) ~[securejarhandler-2.1.10.jar:?] {} 06.05 17:43:24 [Server] INFO at cpw.mods.cl.ModuleClassLoader.lambda$findClass$15(ModuleClassLoader.java:219) ~[securejarhandler-2.1.10.jar:?] {} 06.05 17:43:24 [Server] INFO at cpw.mods.cl.ModuleClassLoader.loadFromModule(ModuleClassLoader.java:229) ~[securejarhandler-2.1.10.jar:?] {} 06.05 17:43:24 [Server] INFO at cpw.mods.cl.ModuleClassLoader.findClass(ModuleClassLoader.java:219) ~[securejarhandler-2.1.10.jar:?] {} 06.05 17:43:24 [Server] INFO at cpw.mods.cl.ModuleClassLoader.loadClass(ModuleClassLoader.java:135) ~[securejarhandler-2.1.10.jar:?] {} 06.05 17:43:24 [Server] INFO at java.lang.ClassLoader.loadClass(ClassLoader.java:525) ~[?:?] {} 06.05 17:43:24 [Server] INFO at java.lang.ClassLoader.defineClass0(Native Method) ~[?:?] {} 06.05 17:43:24 [Server] INFO at java.lang.System$2.defineClass(System.java:2324) ~[?:?] {} 06.05 17:43:24 [Server] INFO at java.lang.invoke.MethodHandles$Lookup$ClassDefiner.defineClass(MethodHandles.java:2439) ~[?:?] {} 06.05 17:43:24 [Server] INFO at java.lang.invoke.MethodHandles$Lookup$ClassDefiner.defineClassAsLookup(MethodHandles.java:2420) ~[?:?] {} 06.05 17:43:24 [Server] INFO at java.lang.invoke.MethodHandles$Lookup.defineHiddenClass(MethodHandles.java:2127) ~[?:?] {re:mixin} 06.05 17:43:24 [Server] INFO at java.lang.invoke.InnerClassLambdaMetafactory.generateInnerClass(InnerClassLambdaMetafactory.java:407) ~[?:?] {} 06.05 17:43:24 [Server] INFO at java.lang.invoke.InnerClassLambdaMetafactory.spinInnerClass(InnerClassLambdaMetafactory.java:315) ~[?:?] {} 06.05 17:43:24 [Server] INFO at java.lang.invoke.InnerClassLambdaMetafactory.buildCallSite(InnerClassLambdaMetafactory.java:228) ~[?:?] {} 06.05 17:43:24 [Server] INFO at java.lang.invoke.LambdaMetafactory.metafactory(LambdaMetafactory.java:341) ~[?:?] {} 06.05 17:43:24 [Server] INFO at java.lang.invoke.BootstrapMethodInvoker.invoke(BootstrapMethodInvoker.java:134) ~[?:?] {} 06.05 17:43:24 [Server] INFO at java.lang.invoke.CallSite.makeSite(CallSite.java:315) ~[?:?] {re:mixin} 06.05 17:43:24 [Server] INFO at java.lang.invoke.MethodHandleNatives.linkCallSiteImpl(MethodHandleNatives.java:281) ~[?:?] {} 06.05 17:43:24 [Server] INFO at java.lang.invoke.MethodHandleNatives.linkCallSite(MethodHandleNatives.java:271) ~[?:?] {} 06.05 17:43:24 [Server] INFO at com.Polarice3.Goety.client.particles.WindBlowParticle$Option.Steps to reproduce
Run the mod on a dedicated server.
Additional information
No response