update font to public sans

Police-Data-Accessibility-Project / data-sources-app

An API and UI for using and maintaining the Data Sources database

MIT License

2 stars 5 forks source link

update font to public sans #368

Open josh-chamberlain opened 1 month ago

josh-chamberlain commented 1 month ago

Context

We switched to Public Sans: https://github.com/Police-Data-Accessibility-Project/design-system/pull/95 Related to https://github.com/Police-Data-Accessibility-Project/pdap.io/issues/178

Requirements

[x] wait until this issue is deployed in a new design system version: https://github.com/Police-Data-Accessibility-Project/design-system/pull/95
- it's in this release: https://github.com/Police-Data-Accessibility-Project/design-system/releases/tag/v3.0.0-beta.5
[ ] update to the newest design system version
[ ] add these to the <head> of index.html

  <link rel="preconnect" href="https://fonts.googleapis.com">
  <link rel="preconnect" href="https://fonts.gstatic.com" crossorigin>
  <link href="https://fonts.googleapis.com/css2?family=Public+Sans:wght@100..900&display=swap" rel="stylesheet">

phillitrOSU commented 1 month ago

Hi, I'd like to tackle this.

josh-chamberlain commented 1 month ago

@phillitrOSU thanks, feel free to take a crack at it!

You shouldn't need many of the environment variables since this is just a visual change. If you wouldn't mind taking care of the related issue (same thing in another repo) it'll help keep things looking similar.

the design-system version needs to be this one for this to work. I think we might want to wait until we merge beta into main, though, which we can do imminently. I'll reach out to @joshuagraber

joshuagraber commented 1 month ago

Hey @phillitrOSU I've released v3.0.0 of pdap-design-system, so you should be good to bump to that version and tackle this.

@josh-chamberlain We'll need to merge this basic PR before @phillitrOSU begins work here, as we still had one stray instance of one of the deprecated components that are now removed in the design system. Glad I thought to check that 😅 .

josh-chamberlain commented 1 month ago

nice catch @joshuagraber, for the main site we'll want to close this one too https://github.com/Police-Data-Accessibility-Project/pdap.io/issues/164

joshuagraber commented 1 month ago

For sure @josh-chamberlain I'll tackle this next week.

phillitrOSU commented 1 month ago

Thanks guys : ). Really interested in this project in general. I'll take a look tomorrow and see if I can get it and related issue taken care of.

phillitrOSU commented 1 month ago

https://github.com/Police-Data-Accessibility-Project/data-sources-app/pull/373