Consolidate/Resolve `data_sources` columns `data_portal_type` and `data_portal_type_other`

Police-Data-Accessibility-Project / data-sources-app

An API and UI for using and maintaining the Data Sources database

MIT License

3 stars 5 forks source link

Consolidate/Resolve `data_sources` columns `data_portal_type` and `data_portal_type_other` #466

Open maxachis opened 2 weeks ago

maxachis commented 2 weeks ago

Context

Currently, the data_portal_type and data_portal_type_other columns in the data_sources table have a lot of overlap with each other.
For example, both columns include MuckRock as one of their potential data portal types, and in some cases SWIFTREPOSITORY, PowerDMS, and MuckRock are listed simultaneously for both columns.
We should probably consolidate these to simplify logic. But how?

Requirements

TODO

Tests

TODO

Docs

TODO

Open questions

TODO

josh-chamberlain commented 2 weeks ago

the data_portal_other is only used for submission; part of the intake process is noticing if there's a value there, and adding a data_portal_type if it wasn't on the list. IMO, for now, it's fine to have the data_portal_other field be inconsistent and weird, since we are only showing data_portal_type to people.