search

Police-Data-Accessibility-Project / design-system

Vue component library and assets for PDAP-branded client apps
MIT License
0 stars 0 forks source link

feat(components): dropdown (#80) #80

Closed joshuagraber closed 5 months ago

joshuagraber commented 6 months ago

Adds dropdown

To test

  1. Pull this branch, run the demo app locally with npm run dev
  2. Check the behavior, styling, and accessibility of the dropdown component.
joshuagraber commented 5 months ago

Hey @josh-chamberlain Thank you for having a look.

I believe I've fixed the animation issue.

i think we should generally default to adding a 1px box around anything interactable if the background is not shaded, so that the bounding box of clickable things is clear. maybe ugly at first.

Can I ask a bit more about this? Do you mean a border, or a whole separate box? Regardless, the pointer cursor should signal what is "clickable," no? FWIW, for keyboard navigation, you should already see an outline from the browser when the element is focused.

My inclination is to not bake that into the component and add those styles at the page level. Wyt about that idea?

josh-chamberlain commented 5 months ago

@joshuagraber nice, thank you! it seems fixed for me too.

yeah, I retract that box feedback for now! Design noodling can come later.

joshuagraber commented 5 months ago

Alright, sounds good to me! Merging. We can always do a clean-up PR at the end of this work, too.

github-actions[bot] commented 5 months ago

:tada: This PR is included in version 2.7.0-beta.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: