search

PolicyEngine / openfisca-tools

Python tools for enhancing OpenFisca country packages.
1 stars 1 forks source link

Remove `amount_over` #13

Open MaxGhenis opened 2 years ago

MaxGhenis commented 2 years ago

I'm unsure of the value of amount_over, which is currently used inconsistently over max_. I can see how it's more descriptive, but it's not completely obvious which argument is over which, and max_ will be familiar to more developers. It's also a bit less concise:

amount_over(x, y)
max_(x - y, 0)

I'd favor removing it at this point, but if we keep it, I'd suggest switching all relevant max_ statements over to it in openfisca-uk and openfisca-us.

nikhilwoodruff commented 2 years ago

OK, leaving in to avoid breaking anything, but adding a deprecation warning.

MaxGhenis commented 2 years ago

Leaving open until we remove in a future version.