PollyNET / Pollynet_Processing_Chain

NRT lidar data processing program for multiwavelength polarization Raman lidar network (PollyNET)
https://polly.tropos.de/
GNU General Public License v3.0
20 stars 8 forks source link

Warnings if paramter in netcdf files are missing #142

Open HolgerPollyNet opened 2 years ago

HolgerPollyNet commented 2 years ago

While implementing the 1064 depol, I realized that the dead time correction parameters in the polly netcdf were missing. It took me ages to find this bug ;-). In the end, only 14 instead of 15 polynomial coefficients were stored in the netcdf and the polynomials 0 0 0 0 0 were used to apply the dead time correction.

I wonder if it would be easy and feasible to output a warning in such case and the use no deadtime correction instead e.g. by applying 0 1 0 0 0 .

This holds also for other parameters which should be stored in the netcdf.

ZPYin commented 2 years ago

For fixing the issue you are facing with, I would suggest to use the user defined deadtime parameters under deadtime correction mode 3.

You can see the polly config file pollyxt_tropos_config_20170319.json in the server to know how to configure a user defined polynomial coefficients for deadtime correction. And don't forget to change dtCorMode to 3.

Regarding output warning for other missing netcdf parameters, it can be complicated, depending on how you would like the processing chain to react when polly netcdf file is not as expected. Do you want it to jump over the current file or do you want it to continue in a correct way? So far, the second approach is preferred and implemented in the processing chain. However, it introduces complexity, by finding a suitable default value.

I would suggest to follow this idea and only extend it when it's necessary.