PolyMathOrg / PolyMath

Scientific Computing with Pharo
MIT License
170 stars 39 forks source link

Refactor FFT tests: Extract Duplicate Code To An Intention-Revealing Custom Assertion #252

Closed hemalvarambhia closed 2 years ago

hemalvarambhia commented 2 years ago

Extracting duplicate to a method felt like the most conservative step forward and is an appeal to Kent Beck's Four Rules of Simple Design.

Naming the assertion is proving difficult and so it may be preferable to keep the duplication.

hemalvarambhia commented 2 years ago

I chose to close this as I would prefer duplication after discovering I had trouble naming the custom assertion.