search

Polymer / tools

Polymer Tools Monorepo
BSD 3-Clause "New" or "Revised" License
430 stars 200 forks source link

Add device to sauce configuration #943

Open jannakha opened 9 years ago

jannakha commented 9 years ago

currently I'm running tests with following configuration: wct --plugin sauce --sauce "OS version/browser@version", eg wct --plugin sauce --sauce "OSX 10.10/safari@8.0"

Could you add configuration to support device types too? wct --plugin sauce --sauce "OS version/browser@version/device/orientation", eg wct --plugin sauce --sauce "Linux 4.4/android/Google Nexus 7 HD Emulator/portrait wct --plugin sauce --sauce "iOS 8.2/safari/iPad Simulator/portrait

thanks!

apowers313 commented 9 years ago

Here's the regex string for line 15 of browsers.js: ^([^\/@]+)\/([^\/@]+)(?:@([^\/])(?:\/([^\/]))?(?:\/([^\/]*))?)?$

At line 52 it generates match[4] for "device" and match[5] for "orientation" that can be used around line 62.

I'll submit a PR with the working code, if one would be welcome.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.