search

PolymerElements / app-localize-behavior

Polymer behaviour to help internationalize your application
48 stars 55 forks source link

Possible documentation correction needed #67

Closed RyanCopley closed 7 years ago

RyanCopley commented 7 years ago

So first off, I'm fairly new to Polymer and its documentation system, but I noticed that between this

PR: https://github.com/PolymerElements/app-localize-behavior/pull/55, this code: https://github.com/PolymerElements/app-localize-behavior/blob/master/app-localize-behavior.html#L247-L251 and this documentation: https://elements.polymer-project.org/elements/app-localize-behavior?active=Polymer.AppLocalizeBehavior#method-loadResources

That the events on the documentation haven't been updated: https://i.imgur.com/RelrNad.png

Not sure how to fix this myself, but I thought i'd point it out:)

RyanCopley commented 7 years ago

(Clears throat realizing I sound like an unorganized person) My suggestion is to change the following on the polymer-project.org documentation:

app-resources-error -> app-localize-resources-error app-resources-loaded -> app-localize-resources-loaded

notwaldorf commented 7 years ago

Oh! These are fixed in master (https://github.com/PolymerElements/app-localize-behavior/blob/master/app-localize-behavior.html#L103), I guess we haven't done a re-push of the catalog to update it

RyanCopley commented 7 years ago

Yeah I noticed they were fixed in the project but wasn't sure what had to happen to republish it to that site:)

notwaldorf commented 7 years ago

Working with @blasten on redeploying the site. Closing this!