PolymerElements / font-roboto

Loads the Roboto family of fonts from Google Fonts.
5 stars 35 forks source link

Relative protocol in font URL breaks in Chrome extension #2

Closed OliverJAsh closed 9 years ago

OliverJAsh commented 9 years ago

https://github.com/PolymerElements/paper-styles/blob/d23af125cb74978532c25e5cd152f9b2e6d991c8/typography.html#L11

This will resolve to chrome://, which obviously will never work.

Can we be explicit about the protocol?

ChrisMcKenzie commented 9 years ago

relative protocol are also now considered an anti-pattern http://www.paulirish.com/2010/the-protocol-relative-url/

jscissr commented 9 years ago

An explicit protocol wouldn't help for Chrome Apps, since external resources are disallowed. The only solution is to have a copy of the .css and the font files in this repo. Also +1

shycherry commented 9 years ago

same problem when using this with NW.js... +1 ! (will resolve to file:// ...)

isaldarriaga commented 9 years ago

same problem for cordova. (will resolves to file:// ... )

dfreedm commented 9 years ago

Fixed by fcda0585729e698716a89b262c583ed5a24f16ec