search

PolymerElements / font-roboto

Loads the Roboto family of fonts from Google Fonts.
5 stars 35 forks source link

Allow user to opt out of font loading #27

Closed rictic closed 6 years ago

rictic commented 6 years ago

For users that are bringing their own fonts, this request is pure overhead. This is a simple mechanism letting them opt out.

bicknellr commented 6 years ago

I'm not sure why we need to do this: the only things we distribute which depend on @polymer/font-roboto are @polymer/paper-styles (used in classes/typography.js and typography.js) and @polymer/iron-demo-helpers (only intended for demos). Is there somewhere that I'm missing which uses this in a way that doesn't give the user an option?

(for reference: https://www.npmjs.com/browse/depended/@polymer/font-roboto)

rictic commented 6 years ago

classes/typography.js is imported by a number of elements, including paper-item, paper-input, paper-badge, and paper-dialog-behavior

bicknellr commented 6 years ago

My mistake, I was only looking at the direct dependents of font-roboto! Yeah, this does seem to be used in a lot of places. (via typography.js)

rictic commented 6 years ago

No worries! I went down the same route :)