Fix focus. Do not treat enter as special.

cdata commented 9 years ago

This change looks big, but most of it is actually just cleaning up the file and adding comments. Here is a summary of meaningful changes in this commit:

Enter is no longer specifically handled by menu. Instead, activatable items should trigger the activate event as configured (the default is tap).
Tabindex values are now updated to all items in the list. The currently focused item receives a tabindex of 0. All other items receive a tabindex of -1. This fixes the problem of elements with magical default tabindex (button, a etc.) messing up focus order.
Changes to the list of items are observed (via a new event provided by IronSelectableBehavior: iron-items-changed), and tabindex values are reset when it is deemed appropriate to do so.
Now that we are no longer specifically handling enter keypresses, some questionable code that translates the KeyboardEvent into the appropriate activation action has been removed.

notwaldorf commented 9 years ago

@cdata i think this generally looks ok. tests are a bit grumpy.

cdata commented 9 years ago

@notwaldorf I had to tweak some stuff in iron-menubar-behavior. Also, I added unresolved to the demo body. PTAL!

cdata commented 9 years ago

There is a corresponding paper-item PR here: https://github.com/PolymerElements/paper-item/pull/27

notwaldorf commented 9 years ago

lgtm :+1:

PolymerElements / iron-menu-behavior

Fix focus. Do not treat enter as special. #25