search

PolymerElements / iron-menu-behavior

Accessible menu behavior
18 stars 28 forks source link

Inverts arrow key focus movement when in an RTL context. #41

Closed bicknellr closed 8 years ago

bicknellr commented 8 years ago

Needed by PolymerElements/paper-tabs#84.

bicknellr commented 8 years ago

Hmm, wct --sauce default seems to work.

bicknellr commented 8 years ago

I think this needs Polymer/polymer#2717 also.

notwaldorf commented 8 years ago

@bicknellr ping! what's the status of this? (also: tests are hella grumpy)

bicknellr commented 8 years ago

update: Polymer/polymer#2717 is in as of not too long ago, but it isn't in a release yet so this is still blocked.

bicknellr commented 8 years ago

I took out all the setTimeout calls and it the tests still work as expected; I'm guessing it's because the events in these tests are all handled synchronously. Also, there's a few other tests (unrelated to this change other than the activeElement thing) that only use click and could probably go without setTimeout as well.

notwaldorf commented 8 years ago

LGTM % nit. Ship it! :shipit: