search

PolymerElements / iron-menu-behavior

Accessible menu behavior
18 stars 28 forks source link

Fixes #63: Adds `scroll-to-focused-item` to enable scrolling to an item before focusing. #64

Closed bicknellr closed 8 years ago

cdata commented 8 years ago

LGTM 👍

bicknellr commented 8 years ago

Just tried this with paper-dropdown-menu and it doesn't work because the iron-overlay is what ends up overflowing and scrolling, not the IronMenuBehavior thing inside. I wouldn't consider this broken with regards to IronMenuBehavior though but it needs another property to specify additional containers that might also crop out the item, or maybe it could recurse up the tree and apply this to all ancestors with scrollHeight > offsetHeight? Also, I'm not sure what the argument to scrollIntoView is meant to do if the element is outside it's nearest scrolling ancestor's scroll bounds in one direction and that element is outside the scroll bounds of another ancestor in the opposite direction.