search

PolymeshAssociation / polymesh-wallet

A Wallet for Polymesh blockchain
Apache License 2.0
13 stars 6 forks source link

Cannot assign a key : bad URI formatting #262

Open kevin-valerio opened 1 year ago

kevin-valerio commented 1 year ago

Small bug due to a missing / between the URL and the path Unchecked runtime.lastError: Invalid url: "http://localhost:3000overview".. So far, I have been facing that problem only using a local node.

image

image

This should be fixable by handling the / in here, by replacing chrome.tabs.create({ url: '${getNetworkDashboardLink()}overview' }) to chrome.tabs.create({ url: '${getNetworkDashboardLink()}/overview' })

Thanks! :)

F-OBrien commented 1 year ago

Thanks for reporting.

I think the issue is that the localhost URL is missing a trailing / when all other ones contain it. https://github.com/PolymeshAssociation/polymesh-wallet/blob/da5b314ec8d63abecd020441415641dca4a0c305/packages/core/src/constants.ts#L45

We'll get this resolved in the next release.