Description

in all dialogs autofocus the positive button this way when the user clicks enter,we automatically performed the positive action. for some reason right now this is not working when a new dialog is opening

Checklist

- [X] Create `src/app/path/to/confirm-dialog/confirm-dialog.component.html` ✓ https://github.com/Polyterative/Patcher/commit/cf990fe3285f45c49f2a436711b60b632a8bef30 [Edit](https://github.com/Polyterative/Patcher/edit/sweep/allow_easy_use_of_keyboard_in_all_dialog/src/app/path/to/confirm-dialog/confirm-dialog.component.html) - [X] Running GitHub Actions for `src/app/path/to/confirm-dialog/confirm-dialog.component.html` ✓ [Edit](https://github.com/Polyterative/Patcher/edit/sweep/allow_easy_use_of_keyboard_in_all_dialog/src/app/path/to/confirm-dialog/confirm-dialog.component.html) - [X] Modify `src/app/features/module-browser/module-browser-adder/module-adder-data.service.ts` ✓ https://github.com/Polyterative/Patcher/commit/91610a04ae6f3968edd964b60ecb0560a0c4dcfb [Edit](https://github.com/Polyterative/Patcher/edit/sweep/allow_easy_use_of_keyboard_in_all_dialog/src/app/features/module-browser/module-browser-adder/module-adder-data.service.ts#L217-L233) - [X] Running GitHub Actions for `src/app/features/module-browser/module-browser-adder/module-adder-data.service.ts` ✓ [Edit](https://github.com/Polyterative/Patcher/edit/sweep/allow_easy_use_of_keyboard_in_all_dialog/src/app/features/module-browser/module-browser-adder/module-adder-data.service.ts#L217-L233) - [X] Modify `src/app/components/rack-parts/rack-detail-data.service.ts` ✓ https://github.com/Polyterative/Patcher/commit/0730cf0b22a3f6e4db59a69848013fa6e5feee93 [Edit](https://github.com/Polyterative/Patcher/edit/sweep/allow_easy_use_of_keyboard_in_all_dialog/src/app/components/rack-parts/rack-detail-data.service.ts#L216-L233) - [X] Running GitHub Actions for `src/app/components/rack-parts/rack-detail-data.service.ts` ✓ [Edit](https://github.com/Polyterative/Patcher/edit/sweep/allow_easy_use_of_keyboard_in_all_dialog/src/app/components/rack-parts/rack-detail-data.service.ts#L216-L233) - [X] Create `src/app/path/to/confirm-dialog/confirm-dialog.component.ts` ✓ https://github.com/Polyterative/Patcher/commit/a6de80a0b5de4e14f29940a636a1e3113d5df85d [Edit](https://github.com/Polyterative/Patcher/edit/sweep/allow_easy_use_of_keyboard_in_all_dialog/src/app/path/to/confirm-dialog/confirm-dialog.component.ts) - [X] Running GitHub Actions for `src/app/path/to/confirm-dialog/confirm-dialog.component.ts` ✓ [Edit](https://github.com/Polyterative/Patcher/edit/sweep/allow_easy_use_of_keyboard_in_all_dialog/src/app/path/to/confirm-dialog/confirm-dialog.component.ts)

🚀 Here's the PR! #111

See Sweep's progress at the progress dashboard!

⚡ Sweep Basic Tier: I'm using GPT-4. You have 3 GPT-4 tickets left for the month and 2 for the day. (tracking ID: 42e6c5617c)

For more GPT-4 tickets, visit our payment portal. For a one week free trial, try Sweep Pro (unlimited GPT-4 tickets).

Install Sweep Configs: Pull Request

[!TIP] I'll email you at vlady.y@live.it when I complete this pull request!

Actions (click)

[ ] ↻ Restart Sweep

GitHub Actions✓

Here are the GitHub Actions logs prior to making any changes:

Sandbox logs for 5cfd1c8

Checking src/app/features/module-browser/module-browser-adder/module-adder-data.service.ts for syntax errors... ✅ src/app/features/module-browser/module-browser-adder/module-adder-data.service.ts has no syntax errors! 1/1 ✓
Checking src/app/features/module-browser/module-browser-adder/module-adder-data.service.ts for syntax errors...
✅ src/app/features/module-browser/module-browser-adder/module-adder-data.service.ts has no syntax errors!

Sandbox passed on the latest develop, so sandbox checks will be enabled for this issue.

Step 1: 🔎 Searching

I found the following snippets in your repository. I will now analyze these snippets and come up with a plan.

Some code snippets I think are relevant in decreasing order of relevance (click to expand). If some file is missing from here, you can mention the path in the ticket description.

https://github.com/Polyterative/Patcher/blob/5cfd1c8bf82ca156be8b93a3ac7f5243be38300b/src/app/shared-interproject/components/@smart/mat-form-entity/mat-form-entity.component.ts#L1-L619 https://github.com/Polyterative/Patcher/blob/5cfd1c8bf82ca156be8b93a3ac7f5243be38300b/src/app/features/module-browser/module-browser-adder/module-adder-data.service.ts#L198-L265 https://github.com/Polyterative/Patcher/blob/5cfd1c8bf82ca156be8b93a3ac7f5243be38300b/src/app/components/rack-parts/rack-detail-data.service.ts#L212-L244 https://github.com/Polyterative/Patcher/blob/5cfd1c8bf82ca156be8b93a3ac7f5243be38300b/src/app/style/reset.scss#L225-L240

Step 2: ⌨️ Coding

[X] Create src/app/path/to/confirm-dialog/confirm-dialog.component.html ✓ https://github.com/Polyterative/Patcher/commit/cf990fe3285f45c49f2a436711b60b632a8bef30 Edit
Create src/app/path/to/confirm-dialog/confirm-dialog.component.html with contents:
• Locate the button element in the `ConfirmDialogComponent`'s HTML template that represents the positive action (e.g., "Submit", "Delete").
• Add the `autofocus` attribute to this button element to ensure it receives focus when the dialog is opened.
• If the `mat-dialog-close` directive is used on the button, ensure that the `autofocus` attribute is added alongside it.
• Repeat this process for any other custom dialog components that may exist in the application where the positive action button should be autofocused.

[X] Running GitHub Actions for src/app/path/to/confirm-dialog/confirm-dialog.component.html ✓ Edit
Check src/app/path/to/confirm-dialog/confirm-dialog.component.html with contents:

Ran GitHub Actions for cf990fe3285f45c49f2a436711b60b632a8bef30:

[X] Modify src/app/features/module-browser/module-browser-adder/module-adder-data.service.ts ✓ https://github.com/Polyterative/Patcher/commit/91610a04ae6f3968edd964b60ecb0560a0c4dcfb Edit
Modify src/app/features/module-browser/module-browser-adder/module-adder-data.service.ts with contents:
• In the `switchMap` operator where the `ConfirmDialogComponent` is opened, ensure that the data passed to the dialog includes a property or flag that indicates the positive button should be autofocused.
• This may involve modifying the `ConfirmDialogDataInModel` to include an `autofocusPositive` property if it does not already exist.

--- 
+++ 
@@ -211,7 +211,8 @@
               negative:    {
                 label: 'Cancel',
                 theme: 'negative'
-              }
+              },
+              autofocusPositive: true
             };

             return this.dialog.open(

[X] Running GitHub Actions for src/app/features/module-browser/module-browser-adder/module-adder-data.service.ts ✓ Edit
Check src/app/features/module-browser/module-browser-adder/module-adder-data.service.ts with contents:

Ran GitHub Actions for 91610a04ae6f3968edd964b60ecb0560a0c4dcfb:

[X] Modify src/app/components/rack-parts/rack-detail-data.service.ts ✓ https://github.com/Polyterative/Patcher/commit/0730cf0b22a3f6e4db59a69848013fa6e5feee93 Edit
Modify src/app/components/rack-parts/rack-detail-data.service.ts with contents:
• Similar to the modification for the module-adder, ensure that the data passed to the `ConfirmDialogComponent` includes an indication that the positive button should be autofocused.
• Modify the `ConfirmDialogDataInModel` if necessary to include an `autofocusPositive` property.

--- 
+++ 
@@ -219,7 +219,8 @@
               title:       'Deletion',
               description: 'Are you sure you want to delete this item?',
               positive:    {label: '✔️ Delete'},
-              negative:    {label: '❌ Cancel'}
+              negative:    {label: '❌ Cancel'},
+              autofocusPositive: true
             };

             return this.dialog.open(

[X] Running GitHub Actions for src/app/components/rack-parts/rack-detail-data.service.ts ✓ Edit
Check src/app/components/rack-parts/rack-detail-data.service.ts with contents:

Ran GitHub Actions for 0730cf0b22a3f6e4db59a69848013fa6e5feee93:

[X] Create src/app/path/to/confirm-dialog/confirm-dialog.component.ts ✓ https://github.com/Polyterative/Patcher/commit/a6de80a0b5de4e14f29940a636a1e3113d5df85d Edit
Create src/app/path/to/confirm-dialog/confirm-dialog.component.ts with contents:
• In the TypeScript file for the `ConfirmDialogComponent`, ensure that the component's logic respects the `autofocusPositive` property from the input data.
• If the property is true, set the autofocus attribute on the positive button programmatically if it cannot be set directly in the template.

[X] Running GitHub Actions for src/app/path/to/confirm-dialog/confirm-dialog.component.ts ✓ Edit
Check src/app/path/to/confirm-dialog/confirm-dialog.component.ts with contents:

Ran GitHub Actions for a6de80a0b5de4e14f29940a636a1e3113d5df85d:

Step 3: 🔁 Code Review

I have finished reviewing the code for completeness. I did not find errors for sweep/allow_easy_use_of_keyboard_in_all_dialog.

🎉 Latest improvements to Sweep:

New dashboard launched for real-time tracking of Sweep issues, covering all stages from search to coding.
Integration of OpenAI's latest Assistant API for more efficient and reliable code planning and editing, improving speed by 3x.
Use the GitHub issues extension for creating Sweep issues directly from your editor.

💡 To recreate the pull request edit the issue title or description. To tweak the pull request, leave a comment on the pull request.^{Something wrong? Let us know.}

This is an automated message generated by Sweep AI.

Polyterative / Patcher

Sweep: allow easy use of keyboard in all dialogs #110