search

PonyGE / PonyGE2

PonyGE2: grammatical evolution and variants in Python
GNU General Public License v3.0
154 stars 91 forks source link

setup file #83

Open aadeshnpn opened 6 years ago

aadeshnpn commented 6 years ago

Currently, PonyGE2 doesn't have a setup file so its a bit hard to include PonyGE2 to other project and reuse its components and tweak its behavior.

I have made changes to PonyGE2 with a setup file so that it can be now installed using pip. Are you interested to merge the changes?

dvpfagan commented 6 years ago

Certainly something we would like to do. Do a merge request so we can do a code review.

Thanks Dave

On 18 January 2018 at 02:04, Aadesh Neupane notifications@github.com wrote:

Currently, PonyGE2 doesn't have a setup file so its a bit hard to include PonyGE2 to other project and reuse its components and tweak its behavior.

I have made changes to PonyGE2 with a setup file so that it can be now installed using pip. Are you interested to merge the changes?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/PonyGE/PonyGE2/issues/83, or mute the thread https://github.com/notifications/unsubscribe-auth/AA8zurC6MWIs9r7ubVJkezUOwfdzhQHQks5tLqapgaJpZM4RiRk7 .

buddha314 commented 6 years ago

@aadeshnpn has this been merged or has a pull request been issued? I'd like to see this feature.

aadeshnpn commented 6 years ago

@buddha314 I haven't sent a pull request. But you can get this feature from my version. https://github.com/aadeshnpn/PonyGE2

nbro commented 3 years ago

@dvpfagan Why wasn't this solved yet? Is PonyGP2 using any package that is also not pip-installable? I don't think so.

This is like the first problem that needs to be solved before anything else. It's impractical nowadays not to have a pip-installable package.

dvpfagan commented 3 years ago

We haven't gotten around to doing this yet. Debate amongst the team as to how best to implement and have PonyGE2 pip installable was the biggest stumbling block.

In the end, we left it as it is. We would obviously welcome any efforts the community might want to make on this front.

Dave

On Wed, 30 Dec 2020 at 14:51, nbro notifications@github.com wrote:

@dvpfagan https://github.com/dvpfagan Why wasn't this solved yet? Is PonyGP2 using any package that is also not pip-installable? I don't think so.

This is like the first problem that needs to be solved before anything else. It's impractical nowadays not to have a pip-installable package.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/PonyGE/PonyGE2/issues/83#issuecomment-752648315, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHTHORZMQGOOWJMWVGPVFTSXM47PANCNFSM4EMJDE5Q .

nbro commented 3 years ago

@dvpfagan Can you just clarify what the problem(s) with creating a setup.py file for PonyGP 2 and make it pip-installable is/are? What debates were you having? Maybe you can share them with us, so that whoever attempts to tackle this problem keeps those issues in mind. I would like to hear them, because I may try to do this.

dvpfagan commented 3 years ago

It mainly boiled down to how we are trying to avoid giving people parameters that could be taken as some form of optimal setup for a problem.

So in an ideal world, we would love to have

import ponyge

ponyge.regression.train(dataset=x, train_test_split= 0.25)

But we would have about 20 or 30 params that would need to be set for this to work out. We didn't want to do things halfway and say use a parameters file in the call.

If it was going to be callable like the above example we didn't want to have a params file.

How best to do that in an intuitive way was where we couldn't agree.

In the end, we basically agreed on the point that the majority of people who would be using this would want to dig in and get their hands dirty with the code so we didn't do it.

Hope that helps.

If someone was to provide a solution then we would obviously review it and add it to the code if it fits the bill.

Dave

On Wed, 30 Dec 2020 at 15:23, nbro notifications@github.com wrote:

@dvpfagan https://github.com/dvpfagan Can you just clarify what the problem with creating a setup.py file for PonyGP 2 is? What debates were you having? Maybe you can share them with us, so that whoever attempts to tackle this problem keeps those issues in mind. I would like to hear them, because I may try to do this.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/PonyGE/PonyGE2/issues/83#issuecomment-752660156, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHTHOWI3BVZ7GUCR5SNK43SXNAYXANCNFSM4EMJDE5Q .

nbro commented 3 years ago

In the end, we basically agreed on the point that the majority of people who would be using this would want to dig in and get their hands dirty with the code so we didn't do it.

So, why don't you simply make a setup.py file without making any assumption about how the user will use the library? Why caring about the parameters at all? Just make a setup.py where people can simply import the public functions and classes. That's it. Note that this issue is orthogonal to getting your hands dirty with the code.

aadeshnpn commented 3 years ago

My version of PonyGE2 setup.py (https://github.com/aadeshnpn/PonyGE2) file works. I would be happy to help to integrate that setup file to this main repo.

a3ahmad commented 3 years ago

My version of PonyGE2 setup.py (https://github.com/aadeshnpn/PonyGE2) file works. I would be happy to help to integrate that setup file to this main repo.

Have you submitted a pull-request with your setup.py?

aadeshnpn commented 3 years ago

My version of PonyGE2 setup.py (https://github.com/aadeshnpn/PonyGE2) file works. I would be happy to help to integrate that setup file to this main repo.

Have you submitted a pull-request with your setup.py?

I think I have in the past. I can send the pull-request again with the setup.py. Do you want that?

a3ahmad commented 3 years ago

Oh, I already copied your setup.py, locally.

I just thought it would be good to put in then main codebase. But, then again, I’m not a maintainer 🙂

dvpfagan commented 3 years ago

Sorry guys if you can just flag up the PR again will take a look and see. Apologies missing it first time I tried to clear a few open PR’s the other week.

Dave

On Sun 18 Jul 2021 at 23:08, a3ahmad @.***> wrote:

Oh, I already copied your setup.py, locally.

I just thought it would be good to put in then main codebase. But, then again, I’m not a maintainer 🙂

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/PonyGE/PonyGE2/issues/83#issuecomment-882122802, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHTHOXVD7IYQCH44YLYNGTTYNGHDANCNFSM4EMJDE5Q .

aadeshnpn commented 3 years ago

Sorry guys if you can just flag up the PR again will take a look and see. Apologies missing it first time I tried to clear a few open PR’s the other week. Dave … On Sun 18 Jul 2021 at 23:08, a3ahmad @.***> wrote: Oh, I already copied your setup.py, locally. I just thought it would be good to put in then main codebase. But, then again, I’m not a maintainer slightly_smiling_face — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#83 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHTHOXVD7IYQCH44YLYNGTTYNGHDANCNFSM4EMJDE5Q .

Thanks @dvpfagan . I will send your a PR request in the weekend with the setup script.