Refactor Kafka person update message creation into a function

PostHog / plugin-server

Service to process and save PostHog events, supporting JS/TS plugins at that

https://posthog.com

8 stars 5 forks source link

Refactor Kafka person update message creation into a function #607

Closed tiina303 closed 3 years ago

tiina303 commented 3 years ago

Changes

Refactoring, this will make it easier to later change the message to have timestamps and last operation. 2 no-op changes.

I'm assuming we don't need to provide the is_deleted: 0 at all if it's 0, which I assume is the default?

Relying on unittests didn't run anything locally, should I?

Checklist

[ ] Updated Settings section in README.md, if settings are affected
[ ] Jest tests

posthog-bot commented 3 years ago

Hey @tiina303! 👋 This pull request seems to contain no description. Please add useful context, rationale, and/or any other information that will help make sense of this change now and in the distant Mars-based future.