PostHog / posthog-flutter

PostHog Flutter SDK
https://posthog.com/docs/libraries/flutter
MIT License
48 stars 34 forks source link

[#96] Fixes PostHogConfig.defaultValue not being found #97

Closed dancamdev closed 3 months ago

dancamdev commented 3 months ago

:bulb: Motivation and Context

This is related to issue #96 and fixes it.

:green_heart: How did you test it?

run flutter build apk and it worked.

:pencil: Checklist

karabanovbs commented 3 months ago

Are this fix will broke capability with previous posthog-android? Looks like that this version shouldn`t working with 3.1.16.

dancamdev commented 3 months ago

I don't know but happy to fix anything that comes up if you have any insights

karabanovbs commented 3 months ago

I don't know but happy to fix anything that comes up if you have any insights

set this version lower then 3.1.17 can help i think https://github.com/PostHog/posthog-flutter/blob/main/android/build.gradle#L58

Im try to do it locally

dancamdev commented 3 months ago

Alright - wondering, why do you care about < 3.1.17 if you're depending on updated versions internally anyway?

karabanovbs commented 3 months ago

because 3.1.17 have breaking changes

marandaneto commented 3 months ago

Oh you beat me to it https://github.com/PostHog/posthog-flutter/pull/98

marandaneto commented 3 months ago

@dancamdev would you like to update the changelog to match https://github.com/PostHog/posthog-flutter/pull/98 or should I merge mine?

dancamdev commented 3 months ago

I'll edit. Thanks

marandaneto commented 3 months ago

Closing it in favor of https://github.com/PostHog/posthog-flutter/pull/98 since the CI is green and I want to cut a release to fix it, will give you credits in the release, thanks @dancamdev