search

PostHog / posthog-java

Official PostHog java library
MIT License
8 stars 12 forks source link

chore(ci): update to jdk 17 #34

Closed pauldambra closed 1 year ago

pauldambra commented 1 year ago

Java 8 is an LTS version but it's pretty old now (released 2014)

Java 17 is the current LTS... You can still run the library in Java 8 even if we're writing it with Java 17

hazzadous commented 1 year ago

@pauldambra I haven't actually tested out the production release functionality yet 🙄

How about I resolve the conflicts here and give the tag thing a go?

pauldambra commented 1 year ago

@hazzadous sounds good to me (particularly since other work has spiralled and I'll not get to this today 😅 )

hazzadous commented 1 year ago

@pauldambra cool I'll get this in, I need a win. I've been trying to get this in but down a rabbit hole with tsc/rollup/babel/polyfills (on the off chance you instantly know a sensible way to validate es5 compat. and polyfilling Promise)

I'll get this in an release 1.2.0? Do you think it's worth a minor release, or maybe a major one?

pauldambra commented 1 year ago

@hazzadous I think I've been a bit backwards here....

The Java 17 runtime can run code compiled by Java 8. But I've done the opposite. This is now generating Java 17 bytecode and a Java 8 runtime doesn't necessarily know how to run it.

I go overexcited. I think this release means our SDK has a floor of Java 17.