PostHog / posthog-js-lite

Reimplementation of posthog-js to be as light and modular as possible.
https://posthog.com/docs/libraries
MIT License
63 stars 31 forks source link

device_name was set to devices user name for all events wrongly #185

Closed marandaneto closed 7 months ago

marandaneto commented 7 months ago

Problem

https://github.com/react-native-device-info/react-native-device-info/blob/e46a5d4dba4e7d1f5e1da8b17c82829600f84d77/ios/RNDeviceInfo/RNDeviceInfo.m#L310-L333 is the correct method. Instead of https://github.com/react-native-device-info/react-native-device-info/blob/e46a5d4dba4e7d1f5e1da8b17c82829600f84d77/ios/RNDeviceInfo/RNDeviceInfo.m#L150-L157 which returns https://developer.apple.com/documentation/uikit/uidevice/1620015-name

Changes

$device_name was set to the device's user name (eg Max's iPhone) for all events wrongly, it's now set to the device's name (eg iPhone 12), this happened only if using react-native-device-info library.

Release info Sub-libraries affected

Bump level

Libraries affected

Changelog notes

github-actions[bot] commented 7 months ago

Size Change: 0 B 🆕

Total Size: 0 B

compressed-size-action