fix: removing session replay button from feature flag create page

[surbhi-posthog]

Removing the "View recordings" button from the Create Feature Flag page and making sure it still exists in the edit/view page

I created a branch that I deprecated and started a new one since I needed to revert too many files. Here is the original PR for reference: https://github.com/PostHog/posthog/pull/26364

Changes

Before	After	After (multi-variant create view)

Verified that the View recordings button is still visible in the view/edit pages:

Unimpacted views

View Page	Edit Page

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

Cloud

How did you test this code?

Verified that button is not seen in the view page, but can still be access in the edit/view pages. tested locally on: http://localhost:8000/project/2/feature_flags/new

[posthog-bot]

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

• chromium: 0 added, 2 modified, 0 deleted (diff for shard 2)
• webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

[surbhi-posthog]

@zlwaterfield @raquelmsmith I noticed that the View recording button is implemented in another place in the same file:

I'm assuming this was built for the multi variant view. I verified that the button does not show up while creating a flag with multi variants.

Should we also try to consolidate button logic into one component? Or does it make sense to keep in separate here?

[github-actions[bot]]

Size Change: 0 B

Total Size: 1.16 MB

ℹ️ View Unchanged

| Filename | Size | | :--- | :---: | | `frontend/dist/toolbar.js` | 1.16 MB |

_{compressed-size-action}

[neilkakkar]

100% optional flyby, I think it makes more sense to re-use the readonly parameter here - recordings button should show only when read only, vs checking the id is not new. It doesn't make too much sense for this button to exist on the edit page either - at the stage its not something editable and clutters the edit screen 😅

[zlwaterfield]

@neilkakkar you're 100% correct, and that was part of the task but I missed it when reviewing. @surbhi-posthog can you make an update to make sure it doesn't in create or edit?

[surbhi-posthog]

Sure thing! I initially left the button on the edit page, thinking it might be useful for users to check session relays while editing the feature flag. That said, I trust your judgment on use behaviors, so I’ll go ahead and make the change.

[surbhi-posthog]

updated logic to use the readOnly flag instead here: https://github.com/PostHog/posthog/pull/26451