fix(data-warehouse): Allow the choice of SSL for mysql connections

PostHog / posthog

🦔 PostHog provides open-source web & product analytics, session recording, feature flagging and A/B testing that you can self-host. Get started - free.

https://posthog.com

Other

22.33k stars 1.35k forks source link

fix(data-warehouse): Allow the choice of SSL for mysql connections #26510

Closed Gilbert09 closed 3 days ago

Gilbert09 commented 3 days ago

Problem

Adding in mandatory SSL support for mysql connections caused syncs to break for a customer (see ticket)

Changes

Updated the UI to let users choose whether they want to use SSL for the connection
Defaults to true everywhere to mimic existing behavior

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

Stepped through locally

github-actions[bot] commented 3 days ago

Size Change: 0 B

Total Size: 1.16 MB

ℹ️ View Unchanged

| Filename | Size | | :--- | :---: | | `frontend/dist/toolbar.js` | 1.16 MB |

_{compressed-size-action}

Gilbert09 commented 3 days ago

Are there any potential security issues here with user data being sent to us without encryption? eg did we enforce SSL for a reason previously?

Dont think so - we enabled it for planetscale databases which required it

sentry-io[bot] commented 3 days ago

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

‼️ AttributeError: 'str' object has no attribute 'get' /api/projects/{parent_lookup_team_id}/external_... View Issue
‼️ InternalError: (81, 'Database dev_test does not exist') /api/projects/{parent_lookup_team_id}/external_... View Issue

_{Did you find this useful? React with a 👍 or 👎}