PowerDNS / pdns

PowerDNS Authoritative, PowerDNS Recursor, dnsdist
https://www.powerdns.com/
GNU General Public License v2.0
3.72k stars 912 forks source link

rec: fix a difference between record-cache hit and miss in some ServFail results #14822

Closed omoerbeek closed 3 weeks ago

omoerbeek commented 3 weeks ago

Short description

Specifically when the max CNAME chain length is exceeded (with QName Minimization enabled), but there are likely other cases.

Fixes #14310

Checklist

I have:

coveralls commented 3 weeks ago

Pull Request Test Coverage Report for Build 11686424851

Details


Files with Coverage Reduction New Missed Lines %
pdns/webserver.hh 1 69.16%
pdns/recursordist/sortlist.hh 1 75.0%
pdns/iputils.hh 1 78.25%
pdns/dnstap.cc 2 70.97%
ext/probds/murmur3.cc 2 94.12%
pdns/sstuff.hh 2 56.83%
pdns/dnsname.hh 2 91.68%
pdns/opensslsigners.cc 2 61.07%
pdns/recursordist/secpoll-recursor.cc 2 51.02%
pdns/rcpgenerator.cc 2 89.77%
<!-- Total: 5225 -->
Totals Coverage Status
Change from base Build 11681769272: -0.06%
Covered Lines: 125342
Relevant Lines: 163095

💛 - Coveralls