PowerShell / DscResource.Tests

Common meta tests for PowerShell DSC resources repositories.
MIT License
51 stars 49 forks source link

Hashtable check - Fix for DSC composite resources #356

Closed SSvilen closed 4 years ago

SSvilen commented 4 years ago

Pull Request (PR) description

As mentioned in this PR, the DSC composite resources are also being parsed as hashtables. I have wrote a fix, that should remove the false/positives on those resources. I have tested it against few DSC Resources - I have not observed any false positives.

This Pull Request (PR) fixes the following issues

PR

Task list


This change is Reviewable

codecov-io commented 4 years ago

Codecov Report

Merging #356 into dev will increase coverage by <1%. The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff          @@
##            dev   #356    +/-   ##
====================================
+ Coverage    84%    84%   +<1%     
====================================
  Files        12     12            
  Lines      1750   1750            
  Branches      2      2            
====================================
+ Hits       1474   1477     +3     
+ Misses      274    271     -3     
  Partials      2      2
mhendric commented 4 years ago

Hey @SSvilen and @PlagueHO , just wanted to check on the review status for this one. Not sure who owns the next action at the moment...

SSvilen commented 4 years ago

I think @PlagueHO or @johlju needs to review the change. @gaelcolas already merged that change in the new DscResource.AnalyzerRules module.