search

PowerShell / EditorSyntax

PowerShell syntax highlighting for editors (VS Code, Atom, SublimeText, TextMate, etc.) and GitHub!
MIT License
133 stars 45 forks source link

Colors on Monokai lost after upgrade to VSCode 1.26 #130

Open PrzemyslawKlys opened 6 years ago

PrzemyslawKlys commented 6 years ago

Environment

Issue Description

Upgraded to 1.26 today, after restart things look weird...

Screenshots

image

Expected Behavior

Colorization should work as before.

PrzemyslawKlys commented 6 years ago

Referencing https://github.com/PowerShell/EditorSyntax/issues/129 as while it talks about Insider release, it's not Insider anymore. Was released to public today.

msftrncs commented 6 years ago

looking at #129, I have to disagree that the changes are all bad, though some changes were unexpected, the changes are making some things more like PowerShell ISE, while somethings have become broken, compared to PowerShell ISE. There are still some colorization that isn't working right, some of it is that themes don't colorize everything they probably should, and others are more complex like supporting subexpressions inside expandable strings really needs the ability to drop the string scope, or all themes to understand that its possible to have code inside a string.

I do believe there needed to be a little focus given to the themes that ship with VS Code, notably in this case, PowerShell ISE theme, as it no longer accomplishes some of the objectives (matching PowerShell ISE no less), and that would have helped the VS Code 1.26 release not be such a notable change.

See #132 for an example of something that still doesn't theme correctly (my opinion) due to scoping.

PrzemyslawKlys commented 6 years ago

I am simply reporting issue. Whether it was needed or not that is not really my decision. I would like colors back but I can adjust. I’m not die hard against this change as VsCode has its own issues when I use it. So I can live few moments with problems as long in the long run it will be better.