PowerShell / PSDscResources

MIT License
129 stars 53 forks source link

Move to 3 part version number #179

Open kilasuit opened 4 years ago

kilasuit commented 4 years ago

Please move this module from a 4 part 1.0.0.0 version to a 3 part 1.0.0 version number to match with https://semver.org/

PlagueHO commented 4 years ago

Hi @kilasuit, this module is still going to be released by the current Microsoft release process. @mgreenegit - is it possible to adjust the release process for this module to do this? We've started to do this for all the other DSC community resource modules.

Is it worth migrating this DSC resource module to use the same CI/CD release process as the DSC community modules as well at some point? Obviously additional controls would need to be implemented to meet the internal Microsoft requirements. Is this worth discussion on community call?

mgreenegit commented 4 years ago

I will bring this up in scrum today and report back.

brajjan commented 3 years ago

Any news to this? We are using Inedo ProGet as our internal package repository - using Publish-Module to publish it to our repository. Nuspec-file gets created with version 2.12.0 and psd1-file is 2.12.0.0 PowershellGet version is 2.2.5


Performing the operation "Publish-Module" on target "Version '2.12.0.0' of module 'PSDscResources'".
VERBOSE: Calling Publish-PSArtifactUtility
VERBOSE: Calling New-NuspecFile
VERBOSE: Calling New-NugetPackage
...
...
VERBOSE: Created Nuget Package C:\Users\username\AppData\Local\Temp\1014885127\PSDscResources\PSDscResources.2.12.0.nupkg
VERBOSE: Successfully created nuget package at C:\Users\username\AppData\Local\Temp\1014885127\PSDscResources\PSDscResources.2.12.0.nupkg
gaelcolas commented 3 years ago

@brajjan your issue is unrelated to the PSDscResources module, as far as I understand. That said, I think you have this issue because of the PackageManagement & PowerShellGet module version you are using are old and buggy (the ones coming by default with windows should be removed). Install the latest PowerShellGet module (2.2.5 as of today), and remove the older ones (i.e. PackageManagement 1.0.0.1 and PowerShellGet 1.0.0.1 (if I remember correctly).

brajjan commented 3 years ago

@gaelcolas not releated to that as I am running the latest PowerShellGet and PackageManagement modules

S C:\> Get-Module PowerShellGet, PackageManagement -ListAvailable

    Directory: C:\Program Files\WindowsPowerShell\Modules

ModuleType Version    Name                                ExportedCommands
---------- -------    ----                                ----------------
Script     1.4.7      PackageManagement                   {Find-Package, Get-Package, Get-PackageProvider, Get-PackageSource...}
Script     2.2.5      PowerShellGet                       {Find-Command, Find-DSCResource, Find-Module, Find-RoleCapability...}

PS C:\> C:\ProgramData\Microsoft\Windows\PowerShell\PowerShellGet\nuget.exe
NuGet Version: 5.9.1.11

But it might be related to nuget version as of this issue https://github.com/NuGet/Home/issues/3050