search

PowerShell / PSResourceGet

PSResourceGet is the package manager for PowerShell
https://www.powershellgallery.com/packages/Microsoft.PowerShell.PSResourceGet
MIT License
498 stars 95 forks source link

[beta10] Main Package should not be installed before dependent packages succeed #251

Open JustinGrote opened 4 years ago

JustinGrote commented 4 years ago

Steps to Reproduce

  1. Install-PSResource Az.Compute -Verbose
  2. Press ctrl-c to simulate a failure after az.compute has been installed
  3. Try importing az.compute, it will fail because dependent module Az.Accounts is not present

Recommended Resolution

Install dependent packages before installing the main package.

Further, why not just use Nuget's already very robust dependency handling and resolution rather than rolling a separate solution for PSGet? This article referenced from MS documentation explains some very good and high performance ways to go about that and I would have expected this module to basically ape this procedure:

https://martinbjorkstrom.com/posts/2018-09-19-revisiting-nuget-client-libraries

issue-label-bot[bot] commented 4 years ago

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.83. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

SydneyhSmith commented 4 years ago

Thanks @JustinGrote we agree that this is worthwhile, although havent determined the amount of work required so havent scoped it to a particular preview release yet