PraxiveSoftware / Samurai

🐉 Build firefox forks with ease. Fork of the gluon project improved for windows.
https://praxive.gitbook.io/samurai
Mozilla Public License 2.0
5 stars 1 forks source link

Issue when setting brand to stable #47

Closed binary-blazer closed 1 month ago

binary-blazer commented 1 month ago
Hey @binary-blazer! That did help and I was able to complete the bootstrap and the build without any issues! However, I ran into a new issue when I ran "samurai set brand stable":
C:\Users\petar\AppData\Local\pnpm\global\5\.pnpm\@praxive+samurai@1.1.2\node_modules\@praxive\samurai\dist\index.js:37
        value: brandConfig.release.displayVersion,
                                   ^

TypeError: Cannot read properties of undefined (reading 'displayVersion')
    at Object.<anonymous> (C:\Users\petar\AppData\Local\pnpm\global\5\.pnpm\@praxive+samurai@1.1.2\node_modules\@praxive\samurai\dist\index.js:37:36)
    at Module._compile (node:internal/modules/cjs/loader:1369:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1427:10)
    at Module.load (node:internal/modules/cjs/loader:1206:32)
    at Module._load (node:internal/modules/cjs/loader:1022:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:135:12)
    at node:internal/main/run_main_module:28:49

Node.js v20.12.2

Originally posted by @leptr in https://github.com/PraxiveSoftware/Samurai/issues/36#issuecomment-2275572414

binary-blazer commented 1 month ago

@leptr It is possible that the brand "stable" is not properly set in your samurai.json config. Can you please share your config file content?

Regards