search

Praxxian / lava-flow

A Foundry VTT module that allows you to import your notes from Obsidian MD into Foundry journal entries.
MIT License
58 stars 9 forks source link

Obsidian links to non-existant notes display as null in Foundry journal #43

Open kuchrk24 opened 10 months ago

kuchrk24 commented 10 months ago

Would be nice if it would build those as the text of the link without the reference to another journal.

image image

Praxxian commented 10 months ago

Yeah I'll need to add this scenario to the test vault so I don't break this in the future. Clearly unexpected behavior during the link conversion process.

captaingoodnight commented 5 months ago

At least as far as images go, if you use an S3 compatible service from anyone other than AW, the endpoint naming convention is different so the link points to the wrong place.

Currently, you hardcode s3 and amazonaws.com in the link. path = https://${settings.s3Bucket}.s3.${settings.s3Region}.amazonaws.com/${path};

For a service like DigitalOcean, their endpoint name is https:\{s3Bucket}.{s3Region}.digitaloceanspaces.com

Kind of a pain to have to support multiple providers with different naming conventions.

Praxxian commented 3 months ago

@kuchrk24 are you able to reproduce this behavior on the latest version? I cannot. I think this was fixed along with several things.

@captaingoodnight I think the S3 issue got resolved via another ticket. I did not have the FilePicker implemented incorrectly. So if you are able to use alternative services in your foundry config, it should work. Can you try this on the latest module version? Thanks!

kuchrk24 commented 3 months ago

Yes, it just shows the name now. Much better, thank you.

image