Data type mismatch between spec and implementation causes black bars to appear in fused images

PreibischLab / BigStitcher

ImgLib2/BDV implementation of Stitching for large datasets

GNU General Public License v2.0

68 stars 15 forks source link

Data type mismatch between spec and implementation causes black bars to appear in fused images #129

Closed zacsimile closed 7 months ago

zacsimile commented 1 year ago

See https://forum.image.sc/t/bigstitcher-image-fusion-produces-black-bars/85726. This seems to be related to #60. BDV published its spec as expecting uint16 data sources. However, BigStitcher expects int16. I would suggest either supporting automatic casting of uint16 data to int16 on load, or making the correct spec easy to access, maybe by putting it on the BigStitcher ImageJ page.

zacsimile commented 1 year ago

Is the underlying assumption that most people are using 8- or 12-bit cameras? Or that the user will rescale counts in [0, 65535] to [-32768, 32767]?

zacsimile commented 7 months ago

This was a BDV issue, fixed last year, and solved in new writers by specifying an explicit data type in the setup level attributes.