avoid out of bounds exception in BDV PopupStitching for 2D datasets

PreibischLab / BigStitcher

ImgLib2/BDV implementation of Stitching for large datasets

GNU General Public License v2.0

68 stars 15 forks source link

avoid out of bounds exception in BDV PopupStitching for 2D datasets #57

Closed NicoKiaru closed 5 years ago

NicoKiaru commented 5 years ago

check setup dimension before testing its size

StephanPreibisch commented 5 years ago

Hi, when is this happening? This .numDimensions() call should never return 2 ...

StephanPreibisch commented 5 years ago

Oh, and thanks :)

NicoKiaru commented 5 years ago

Sorry it was indeed lacking a bit of context ;-). I wrote a new bioformat image loader which works well for slide scanner datasets, which already contain a pyramidal representation ( 2d cf repo : https://github.com/BIOP/bigdataviewer-bioformats ). This error showed up and prevented me to go further. For the moment I have nothing that can be easily shared because it's too early and messy, but I'll do it when I can.

StephanPreibisch commented 5 years ago

Ah, that makes sense then, thanks a lot!