Migrate "Catalog > Attributes & Features > View attribute" page

[matks]

Part of Symfony migration project Type: page

Actually, the "Catalog > Attributes & Features > Attributes" page shows what PrestaShop internally calls "attribute groups". And when we click "view" on an attribute group, we see this page which contains attribute values.

Looks like a regular listing with drag-and-drop for position column. Available through URL admin-dev/sell/catalog/attribute-groups then "view" action

Status

Todo:

• [x] Migrate page (done in https://github.com/PrestaShop/PrestaShop/pull/14040)
• [ ] Add drag-and-drop
• [ ] Fix bug: in legacy page, when you navigate through multiple "view attribute" pages, search filters are reset; in migrated page they are shared

Check-List (copied from #13989)

App layer

Controller / routing

• [ ] All controller actions are migrated and protected with @AdminSecurity annotations when eligible and @DemoRestricted annotations when eligible
• [ ] All links targeting this page are updated: either using _legacy_link or updating the code
• [ ] The new SF routes have _legacy_link and _legacy_parameters provided and explained
• [ ] Controller catches Domain Exception and translate them nicely

  Template

• [ ] Twig templates must contain relevant blocks to allow partial extension by modules
• [ ] Twig forms must have form_rest() and form_errors()
• [ ] JS being used on the page can be used as enabled extensions and use a PageMap for selectors
• [ ] Use @PrestaShop instead of PrestaShopBundle for template root path aliasing

  Conventions

• [ ] The new controller actions comply with our naming convention
• [ ] The new SF routes names and paths comply with our naming convention
• [ ] The new Twig template names comply actions with our naming convention
• [ ] Created files (controller, JS assets, CSS assets and twig views) must be in the right folder following the convention
• [ ] CSS being added must follow theme conventions

Core layer

• [ ] Commands and Queries only use native types but internally use VOs
• [ ] All Handlers must have an Interface

  Conventions

• [ ] The created SF service names comply with our naming convention
• [ ] The created files must follow the folder convention (Domain, Core, Adapter...)

Polishing

• [ ] The legacy controller and templates files are gone
• [ ] If PR includes a new concept/mechanism, documentation must be written
• [ ] JS and CSS assets must be compiled and up-to-date
• [ ] License headers must be up-to-date
• [ ] New hooks have been added to the hooks list and the SQL updates
• [ ] Performance must be correct: page loading time, filtering/sorting/searching response time, actions response time

Testing

• [ ] Commands and Queries are tested with Behat tests
• [ ] Eligible Core classes are covered with unit tests*
• [ ] Controller is covered with survival test
• [ ] (soon) Controller is covered with E2E tests using puppeeter
• [ ] If we break E2E tests because IDs change, we must update the E2E tests

*Eligible = easy to isolate and unit tests provide values (for example testing getters/setters is useless)

[prestashop-issue-bot[bot]]

Thanks for opening this issue! We will help you to keep its state consistent

[matks]

@MatShir Might have already been done by @zuk3975 when he did https://github.com/PrestaShop/PrestaShop/pull/14040

[kpodemski]

@matks is it still planned for 1.7.7?

[zuk3975]

Its already in develop (and i think in 1.7.7) just hidden. You can test it by using admin-dev/sell/catalog/attribute-groups. Added couple screenshots bellow.

[matks]

@matks is it still planned for 1.7.7?

It has been migrated in 1.7.7 but, as @zuk3975 said, it was hidden because the other "Catalog > Attributes & Features" pages were not finished for 1.7.7 and it does not look good to show a group of pages related with half migrated and half legacy.

So it will be made available for 1.7.8 😊

[matks]

@zuk3975 It looks like the following items are missing:

• drag-and-drop rows
• in legacy page, when you navigate through multiple "view attribute" pages, search filters are reset (which makes sense, because it's different listing) ; in migrated page they are shared

I'll do them 😉 so you can focus on Product page