PretendoNetwork / website

Website for Pretendo Network
https://pretendo.network
GNU Affero General Public License v3.0
95 stars 80 forks source link

Update 3ds.md #315

Closed upadsamay387 closed 4 months ago

upadsamay387 commented 4 months ago

Adds small detail on where to link a PNID on 3DS

Resolves #316

Changes:

jonbarrow commented 4 months ago

Please refrain from creating pull requests for issues which have not been approved. The issue you are trying to make changes for has been rejected. The "approved issues'' system is in place for a reason, to prevent things like this. You are also targeting the wrong branch.

You have checked off that you read the contribution guide, however it seems clear that this is not the case;

  1. You did not properly use the approved issues system. This is directly gone over in both the Making Issues and Code Changes sections, stating: When making code changes, an issue for the changes must be made and marked as approved before making the relevant changes. and As stated in Making Issues, before making any code changes there must be an open, approved, issue for them. respectively
  2. Your commits do not follow the guides rules on commit messages.
  3. Your pull request did not fill out the Changes section. This is directly mentioned in the Pull Requests section, stating: Like everything else, pull requests should be as detailed as possible. Your title should adequately summarize the changes being made, and the body of the pull request should fully explain your changes.. This should have been placed in the Changes section. This alone is not something that would typically get a pull request rejected, however it is an indicator that the guide was not read
  4. Your pull request is targeting the wrong branch. This is directly mentioned in the Pull Requests section, stating: Pull requests should never be made against the default (main/master) branch of a repository. The default branch contains the most recent, stable, version of the codebase. All work on the codebase should take place in other branches. Unless otherwise specified, your target branch should typically be the dev branch. You may target other feature branches, however, if need be. If a dev branch does not exist for the repository you are working on, please submit a feature request for one to be added before continuing.
  5. Finally, changes like these would fall under "changes for the sake of changes". There was no objective reason to make these changes, as they added no real substance, and you did not use the correct channels before making said changes. This is directly mentioned in the Quality and Substance section, stating: We do not accept changes for the sake of changes. Changes should solve real problems, not change things for your personal preferences. and However changes like these must still be approved, and justified. If the changes do not provide any true substance, they will likely be rejected.

While we always welcome outside contributions, and we encourage people to do so, we created the contribution guide for a reason and it should be thoroughly read and understood before trying to contribute. Please go back and familiarize yourself with our contribution guidelines before making future changes.

Thank you, and we do hope to see approved contributions from you in the future :+1:. Since the issue this was closing was ultimately rejected, this PR will also be closed.