mulshine
commented
8 years ago Will keep this in mind. Yes, copying some of the data from the NostalgicPreparation in to the NostalgicProcessor class may be the way to go; then only updating when all notes are off.
On Sat, Nov 26, 2016 at 4:05 PM, dantrueman notifications@github.com wrote:
i'm currently saving a pointer to the current nPrep so that when the undertow note is started it uses that preparation and not the current preparation when the undertow note begins, should the preparations have changed since the note was first played. it occurs to me that this could be unsafe in the rare circumstance where there is a nostalgic note playing while the user opens a new library, resetting all the preparations pointers, in which case perhaps nPrep should probably be actually copied to undertowPreparations. we should not forget to evaluate this, as we further development how preparations/presets/libraries are handled.... at the moment it's moot as we only have one preparation, but obviously this will change...
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Princeton-CDH/bitKlavier/issues/12, or mute the thread https://github.com/notifications/unsubscribe-auth/AGlRgOjIMXq6lclDb4pn3WH4_lB3AfKpks5rCJ8igaJpZM4K8_b5 .
i'm currently saving a pointer to the current nPrep so that when the undertow note is started it uses that preparation and not the current preparation when the undertow note begins, should the preparations have changed since the note was first played. it occurs to me that this could be unsafe in the rare circumstance where there is a nostalgic note playing while the user opens a new library, resetting all the preparations pointers, in which case perhaps nPrep should probably be actually copied to undertowPreparations. we should not forget to evaluate this, as we further development how preparations/presets/libraries are handled.... at the moment it's moot as we only have one preparation, but obviously this will change...